Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-44797: [CI] Update pkg-config to pkgconf on Homebrew #44798

Merged
merged 9 commits into from
Nov 21, 2024
Merged

GH-44797: [CI] Update pkg-config to pkgconf on Homebrew #44798

merged 9 commits into from
Nov 21, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Nov 20, 2024 •
edited
Loading

Rationale for this change

Some CI jobs are currently failing on main:

What changes are included in this PR?

Update from deprecated pkg-config to pkgconf

Are these changes tested?

Via CI

Are there any user-facing changes?

No

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #44797 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Nov 20, 2024

weird, the C++ job passes now but the Python one still fails (and the C GLib & Ruby failure might be related)

@raulcd
Copy link
Member Author

raulcd commented Nov 20, 2024

@kou any idea?

@assignUser
Copy link
Member

@raulcd ruby uses pkg-conf via a Gem by kou and it looks like it can't find the new pkgconf. I think you can fix it by setting the envvar https://github.com/ruby-gnome/pkg-config/blob/main/lib/pkg-config.rb#L75

@assignUser
Copy link
Member

For python I think it's because pkg-config is already installed via brew on the runner so it fails linking, removing pkg-config before should fix it: https://github.com/apache/arrow/actions/runs/11936401942/job/33269969915?pr=44798#step:4:65

@kou
Copy link
Member

kou commented Nov 21, 2024

I'll improve the pkg-config gem.

kou
kou reviewed Nov 21, 2024
View reviewed changes
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting review Awaiting review awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 21, 2024
@kou
Copy link
Member

kou commented Nov 21, 2024

Hmm. Meson still uses only pkg-config: mesonbuild/meson#7701

@github-actions github-actions bot added awaiting review Awaiting review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Nov 21, 2024
@kou kou marked this pull request as ready for review November 21, 2024 05:36
raulcd
raulcd commented Nov 21, 2024
View reviewed changes
Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @kou for the fixes!

@raulcd raulcd removed the awaiting review Awaiting review label Nov 21, 2024
@raulcd raulcd added the awaiting merge Awaiting merge label Nov 21, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Nov 21, 2024
@raulcd raulcd added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Nov 21, 2024
kou
kou approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 27bbd59 into apache:main Nov 21, 2024
36 checks passed
@kou kou removed the awaiting merge Awaiting merge label Nov 21, 2024
@kou kou mentioned this pull request Nov 21, 2024
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 21, 2024
@nichollsh nichollsh mentioned this pull request Nov 21, 2024
Closed
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 27bbd59.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@raulcd raulcd mentioned this pull request Nov 22, 2024
Merged
@zeroshade zeroshade mentioned this pull request Nov 22, 2024
Merged
zeroshade added a commit to apache/arrow-go that referenced this pull request Nov 22, 2024
@zeroshade
ci: update pkg-config to pkgconf on Homebrew (#198)
e112ad0 
See apache/arrow#44798

Fixing the CI for macOS by switching to pkgconf from deprecated
pkg-config for Homebrew
@schnellerhase schnellerhase mentioned this pull request Nov 23, 2024
Merged
This was referenced Nov 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulcd @assignUser @kou