-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [CI][C++] Add C++ example builds to "cpp" Crossbow task group #43975
Conversation
@github-actions crossbow submit -g cpp |
Revision: 767de80 Submitted crossbow builds: ursacomputing/crossbow @ actions-4f5e187eb4 |
@kou Is this ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9761241. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#43975) ### Rationale for this change The `python` task group already includes the Python example builds. This PR does the same for the `cpp` task group. ### Are these changes tested? By CI itself. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…pache#43975) ### Rationale for this change The `python` task group already includes the Python example builds. This PR does the same for the `cpp` task group. ### Are these changes tested? By CI itself. ### Are there any user-facing changes? No. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
The
python
task group already includes the Python example builds. This PR does the same for thecpp
task group.Are these changes tested?
By CI itself.
Are there any user-facing changes?
No.