GH-43280: [Python] Prune examples and benchmarks folders from release #43281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
raulcd
reviewed
Jul 22, 2024
Comment on lines
+9
to
+12
| prune benchmarks | ||
| prune cmake_modules | ||
| prune examples | ||
| prune scripts |
There was a problem hiding this comment.
This looks good to me but I honestly prefer the changes here: https://github.com/apache/arrow/pull/43325/files
If we add a new folder or some of those existing ones get removed we don't have to update anything, but we would have to update MANIFEST.in every time, so the changes there feel more future proof to me.
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently
examplesandbenchmarksfolders are installed into the top level install directory, alongsidepyarrow. As these names are very generic, they should either be subfolders insidepyarrowe.g.pyarrow/examples, or otherwise pruned.What changes are included in this PR?
Remove during disting
Are these changes tested?
Locally
Are there any user-facing changes?
Yes, those folders will no longer be installed.
fixes #43280
examplesfolder into python site-packages #43280fixes #43299