-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43116: [C++][Compute] Mark KeyCompare.CompareColumnsToRowsLarge as large memory test #43128
Conversation
|
@github-actions crossbow submit -g cpp |
Revision: 85bf559 Submitted crossbow builds: ursacomputing/crossbow @ actions-5c19a21694 |
@github-actions crossbow submit -g cpp |
Revision: ff8e08c Submitted crossbow builds: ursacomputing/crossbow @ actions-f080521a0f |
@github-actions crossbow submit -g cpp |
1 similar comment
@github-actions crossbow submit -g cpp |
Revision: a1a1ccb Submitted crossbow builds: ursacomputing/crossbow @ actions-0257529eff |
@github-actions crossbow submit -g cpp |
Revision: c81724a Submitted crossbow builds: ursacomputing/crossbow @ actions-3eff9d8bd6 |
@github-actions crossbow submit -g cpp |
Revision: aed0361 Submitted crossbow builds: ursacomputing/crossbow @ actions-07ab3e3101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@felipecrv @bkietz are you ok for me merging this for the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @felipecrv @bkietz are you ok for me merging this for the release?
Sure. Go ahead.
… large memory test (#43128) ### Rationale for this change This test consumes more than 4GB memory and causes oom-kill when running with TSAN as reported in #43116 . ### What changes are included in this PR? Limit its running by marking it as large memory test. ### Are these changes tested? Change is test. ### Are there any user-facing changes? None. * GitHub Issue: #43116 Authored-by: Ruoxi Sun <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5b5c164. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…rge as large memory test (apache#43128) ### Rationale for this change This test consumes more than 4GB memory and causes oom-kill when running with TSAN as reported in apache#43116 . ### What changes are included in this PR? Limit its running by marking it as large memory test. ### Are these changes tested? Change is test. ### Are there any user-facing changes? None. * GitHub Issue: apache#43116 Authored-by: Ruoxi Sun <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Rationale for this change
This test consumes more than 4GB memory and causes oom-kill when running with TSAN as reported in #43116 .
What changes are included in this PR?
Limit its running by marking it as large memory test.
Are these changes tested?
Change is test.
Are there any user-facing changes?
None.