Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-40536: [CI]: Migrate remaining jobs away from self-hosted mac runners. #40537

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Mar 14, 2024

Rationale for this change

CRAN no longer builds on 10.13 and gh provides M1 runners now.

What changes are included in this PR?

use m1 for verify-rc-binaries-wheels-macos-14-arm64:
and macos-11 for r-binary-packages

Are these changes tested?

crossbow

@assignUser assignUser requested review from kou and raulcd as code owners March 14, 2024 03:57
@assignUser
Copy link
Member Author

@github-actions crossbow submit verify-rc-binaries-wheels-macos-14-arm64 r-binary-packages

Copy link

⚠️ GitHub issue #40536 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 14, 2024

This comment was marked as outdated.

@kou
Copy link
Member

kou commented Mar 14, 2024

@github-actions crossbow submit verify-rc-binaries-wheels-macos-14-arm64 --param release=15.0.2 --param rc=3

@assignUser
Copy link
Member Author

ugh, brew doesn't support macos 11 anymore so it tries to build sccache from source...

Warning: You are using macOS 11.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.

Lets just bump to 12, 11 will be removed in Q2 anyway: actions/runner-images#9255

Copy link

Revision: 346c036

Submitted crossbow builds: ursacomputing/crossbow @ actions-1797eb513d

Task Status
verify-rc-binaries-wheels-macos-14-arm64 GitHub Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

Copy link

Revision: 661fa28

Submitted crossbow builds: ursacomputing/crossbow @ actions-52e3f3edc1

Task Status
r-binary-packages GitHub Actions

@kou
Copy link
Member

kou commented Mar 14, 2024

verify-rc-binaries-wheels-macos-14-arm64 worked. I'll unify verify-rc/github.macos.{arm,amd}64.yml.

@kou
Copy link
Member

kou commented Mar 14, 2024

@github-actions crossbow submit verify-rc--macos- --param release=15.0.2 --param rc=3

This comment was marked as outdated.

Because preinstalled Homebrew's Python isn't latest.
@kou
Copy link
Member

kou commented Mar 14, 2024

@github-actions crossbow submit verify-rc--macos- --param release=15.0.2 --param rc=3

This comment was marked as outdated.

Copy link

Revision: 9a5ecad

Submitted crossbow builds: ursacomputing/crossbow @ actions-98b9c07bdc

Task Status
verify-rc-binaries-wheels-macos-11-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-12-amd64 GitHub Actions
verify-rc-binaries-wheels-macos-14-arm64 GitHub Actions
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-csharp-macos-amd64 GitHub Actions
verify-rc-source-csharp-macos-arm64 GitHub Actions
verify-rc-source-go-macos-amd64 GitHub Actions
verify-rc-source-go-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-java-macos-amd64 GitHub Actions
verify-rc-source-js-macos-amd64 GitHub Actions
verify-rc-source-js-macos-arm64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions

@kou
Copy link
Member

kou commented Mar 14, 2024

verify-rc-source-cpp-macos-arm64 and verify-rc-source-cpp-macos-conda-amd64 failures will be passed on main because main has 5127ef0#diff-aa8c7db0f10c202b555dd103c54828afa0e8cbd781e87694b5ac4705beba2cdeR1068 .

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 14, 2024
@raulcd
Copy link
Member

raulcd commented Mar 14, 2024

Thanks both @kou and @assignUser for the effort!

@raulcd raulcd merged commit 9035c4e into apache:main Mar 14, 2024
8 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Mar 14, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9035c4e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 18 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants