GH-40181: [C++] Support glog 0.7 build #40230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g cpp -g r -g linux -g python -g r |
|
Revision: 1475046 Submitted crossbow builds: ursacomputing/crossbow @ actions-5f343110fe
|
1 task
|
Failures look all unrelated, so this is good to go. |
pitrou
reviewed
Feb 27, 2024
| @@ -116,7 +116,7 @@ static std::unique_ptr<std::string> log_dir_; | |||
| #ifdef ARROW_USE_GLOG | |||
|
|
|||
| // Glog's severity map. | |||
| static int GetMappedSeverity(ArrowLogLevel severity) { | |||
| static google::LogSeverity GetMappedSeverity(ArrowLogLevel severity) { | |||
There was a problem hiding this comment.
Does this break compatibility with previous versions? If so, perhaps use auto to be more lenient.
There was a problem hiding this comment.
Ok, I see that previously it was using LogSeverity = int, so nothing should break. Thank you.
github-actions
bot
added
awaiting committer review
pitrou
approved these changes
Feb 27, 2024
|
Thank you. Please note that anything building with ArrowConfig.cmake now fails This was not the case before. Edit: Ah even worse! Even with glog 0.7 being there, providing /usr/lib64/cmake/glog, the build fails because ArrowConfig.cmake can not find uppercas GLOG. |
|
Could you open a new issue for it? |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5ce060a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
Fixes apache#40181 ### Are these changes tested? These changes have been tested as part of the conda feedstocks for Arrow. * GitHub Issue: apache#40181 Authored-by: Uwe L. Korn <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
Fixes apache#40181 ### Are these changes tested? These changes have been tested as part of the conda feedstocks for Arrow. * GitHub Issue: apache#40181 Authored-by: Uwe L. Korn <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40181
Are these changes tested?
These changes have been tested as part of the conda feedstocks for Arrow.