GH-39333: [C++] Don't use "if constexpr" in lambda #39334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit wheel-windows-* |
|
|
github-actions
bot
added
Component: C++
awaiting committer review
This comment was marked as outdated.
This comment was marked as outdated.
kou
force-pushed
the
cpp-list-view-if-constexpr
branch
from
48321ef to
2957d9b
Compare
It seems that it's not portable. At least it doesn't work as expected
with Visual Studio 2017:
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'validity': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
C:/arrow/cpp/src/arrow/array/array_nested.cc(660): note: see reference to function template instantiation 'arrow::Result<std::shared_ptr<arrow::Array>> arrow::`anonymous-namespace'::FlattenListViewArray<arrow::ListViewArray,false>(const ListViewArrayT &,arrow::MemoryPool *)' being compiled
with
[
ListViewArrayT=arrow::ListViewArray
] (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx)
memory_pool.cc
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'list_view_array_offset': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
Use "if constexpr" in outer lambda.
kou
force-pushed
the
cpp-list-view-if-constexpr
branch
from
2957d9b to
47ed583
Compare
|
@github-actions crossbow submit wheel-windows-* |
|
Revision: 47ed583 Submitted crossbow builds: ursacomputing/crossbow @ actions-516f35e778
|
|
@felipecrv This is happen after #35345 is merged. |
pitrou
reviewed
Dec 21, 2023
cpp/src/arrow/array/array_nested.cc
Outdated
| const auto* offsets = list_view_array.data()->template GetValues<offset_type>(1); | ||
| const auto* sizes = list_view_array.data()->template GetValues<offset_type>(2); | ||
|
|
||
| auto is_null_or_empty = [&](int64_t i) { | ||
| if constexpr (HasNulls) { | ||
| std::function<bool(int64_t)> is_null_or_empty; |
There was a problem hiding this comment.
This is complicated. Instead, how about just:
auto is_null_or_empty = [&](int64_t i) {
if (HasNulls && !bit_util::GetBit(validity, list_view_array_offset + i)) {
return true;
}
return sizes[i] == 0;
};
There was a problem hiding this comment.
+1.
The compiler will constant-fold it when the lambda gets inlined. Putting it in std::function would prevent inlining.
|
@github-actions crossbow submit -g cpp wheel-windows-* |
|
Revision: e2ee3d3 Submitted crossbow builds: ursacomputing/crossbow @ actions-0dda7a7461
|
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 5df541d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### Rationale for this change
It seems that it's not portable. At least it doesn't work as expected with Visual Studio 2017:
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'validity': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
C:/arrow/cpp/src/arrow/array/array_nested.cc(660): note: see reference to function template instantiation 'arrow::Result<std::shared_ptr<arrow::Array>> arrow::`anonymous-namespace'::FlattenListViewArray<arrow::ListViewArray,false>(const ListViewArrayT &,arrow::MemoryPool *)' being compiled
with
[
ListViewArrayT=arrow::ListViewArray
] (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx)
memory_pool.cc
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'list_view_array_offset': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
### What changes are included in this PR?
Avoid "if constexpr" in lambda.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: apache#39333
Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change
It seems that it's not portable. At least it doesn't work as expected with Visual Studio 2017:
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'validity': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
C:/arrow/cpp/src/arrow/array/array_nested.cc(660): note: see reference to function template instantiation 'arrow::Result<std::shared_ptr<arrow::Array>> arrow::`anonymous-namespace'::FlattenListViewArray<arrow::ListViewArray,false>(const ListViewArrayT &,arrow::MemoryPool *)' being compiled
with
[
ListViewArrayT=arrow::ListViewArray
] (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx)
memory_pool.cc
C:/arrow/cpp/src/arrow/array/array_nested.cc(291): error C2065: 'list_view_array_offset': undeclared identifier (compiling source file C:\arrow-build\src\arrow\CMakeFiles\arrow_shared.dir\Unity\unity_0_cxx.cxx) [C:\arrow-build\src\arrow\arrow_shared.vcxproj]
### What changes are included in this PR?
Avoid "if constexpr" in lambda.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: apache#39333
Lead-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It seems that it's not portable. At least it doesn't work as expected with Visual Studio 2017:
What changes are included in this PR?
Avoid "if constexpr" in lambda.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.