-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-37307: [Python][CI] Manually skip tests with skip_with_pyarrow_strings marker for nightly dask integration tests #37324
GH-37307: [Python][CI] Manually skip tests with skip_with_pyarrow_strings marker for nightly dask integration tests #37324
Conversation
…ow_strings marker for nightly dask integration tests
|
@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel |
Revision: 393ad32 Submitted crossbow builds: ursacomputing/crossbow @ actions-b710e26fea
|
@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel |
Revision: 604b70c Submitted crossbow builds: ursacomputing/crossbow @ actions-37b5842388
|
@github-actions crossbow submit test-conda-python-3.11-dask-latest test-conda-python-3.11-dask-upstream_devel |
Revision: 950934a Submitted crossbow builds: ursacomputing/crossbow @ actions-6afdafda3e
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c927520. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…ow_strings marker for nightly dask integration tests (apache#37324) ### Rationale for this change Dask added some tests with a custom `@ pytest.mark.skip_with_pyarrow_strings` mark, which ensures to skip some tests when pyarrow is installed. However, that skip doesn't work correctly when running the tests on an installed version of dask with `pytest --pyargs dask.tests`. Therefore manually skipping tests with that mark as a workaround. * Closes: apache#37307 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Rationale for this change
Dask added some tests with a custom
@pytest.mark.skip_with_pyarrow_strings
mark, which ensures to skip some tests when pyarrow is installed. However, that skip doesn't work correctly when running the tests on an installed version of dask withpytest --pyargs dask.tests
.Therefore manually skipping tests with that mark as a workaround.