GH-36720: [R] stringr modifier functions cannot be called with namespace prefix #36758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
paleolimbot
approved these changes
Jul 19, 2023
github-actions
bot
added
awaiting merge
Co-authored-by: Dewey Dunnington <[email protected]>
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
|
CI failure is due to #36787 and not changes in this PR, so I'll merge |
paleolimbot
reviewed
Jul 20, 2023
Comment on lines
+76
to
+80
| function_called <- call_name(pattern[1]) | ||
|
|
||
| if (function_called %in% modifier_funcs) { | ||
| pattern[1] <- call2(function_called) | ||
| } |
There was a problem hiding this comment.
This bit can be reduced to pattern[1] <- call2(function_called) (since is_call() took care of the name/namespace matching).
There was a problem hiding this comment.
Nice catch, will chuck this into a follow-up
github-actions
bot
added
awaiting changes
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this pull request
Jul 20, 2023
…namespace prefix (apache#36758) ### Rationale for this change Bug in implementation of string modified functions caused them to be swallowed when prefixed with stringr namespace ### What changes are included in this PR? Strips out the `stringr::` prefix when expressions contain `stringr::fixed`, `stringr::coll`, `string::boundary` or `stringr::regex` ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#36720 Lead-authored-by: Nic Crane <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Nic Crane <[email protected]>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 819b7d5. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…namespace prefix (apache#36758) ### Rationale for this change Bug in implementation of string modified functions caused them to be swallowed when prefixed with stringr namespace ### What changes are included in this PR? Strips out the `stringr::` prefix when expressions contain `stringr::fixed`, `stringr::coll`, `string::boundary` or `stringr::regex` ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#36720 Lead-authored-by: Nic Crane <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Nic Crane <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…namespace prefix (apache#36758) ### Rationale for this change Bug in implementation of string modified functions caused them to be swallowed when prefixed with stringr namespace ### What changes are included in this PR? Strips out the `stringr::` prefix when expressions contain `stringr::fixed`, `stringr::coll`, `string::boundary` or `stringr::regex` ### Are these changes tested? Yes ### Are there any user-facing changes? Yes * Closes: apache#36720 Lead-authored-by: Nic Crane <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Nic Crane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bug in implementation of string modified functions caused them to be swallowed when prefixed with stringr namespace
What changes are included in this PR?
Strips out the
stringr::prefix when expressions containstringr::fixed,stringr::coll,string::boundaryorstringr::regexAre these changes tested?
Yes
Are there any user-facing changes?
Yes