Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36750: [R] Fix test-r-devdocs on MacOS #36751

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Jul 18, 2023

Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (#31757), so some of the package builds are failing.

What changes are included in this PR?

Use the setup-r-dependencies action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

Are these changes tested?

Yes, as part of the test-r-devdocs job.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #36750 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 18, 2023
@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs

@github-actions
Copy link

Revision: 4c2c06a

Submitted crossbow builds: ursacomputing/crossbow @ actions-ce18fdfab0

Task Status
test-r-devdocs Github Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs

@github-actions
Copy link

Revision: 1d86763

Submitted crossbow builds: ursacomputing/crossbow @ actions-126f08892a

Task Status
test-r-devdocs Github Actions

@paleolimbot
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs

@github-actions
Copy link

Revision: 28df9f4

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c345aed07

Task Status
test-r-devdocs Github Actions

@paleolimbot paleolimbot marked this pull request as ready for review July 20, 2023 16:23
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit d98b3a1 into apache:main Jul 20, 2023
@kou kou removed the awaiting committer review Awaiting committer review label Jul 20, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 20, 2023
@paleolimbot paleolimbot deleted the r-devdocs-action branch July 21, 2023 19:37
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d98b3a1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
### Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing.

### What changes are included in this PR?

Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

### Are these changes tested?

Yes, as part of the test-r-devdocs job.

### Are there any user-facing changes?

No.
* Closes: apache#36750

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing.

### What changes are included in this PR?

Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).

### Are these changes tested?

Yes, as part of the test-r-devdocs job.

### Are there any user-facing changes?

No.
* Closes: apache#36750

Authored-by: Dewey Dunnington <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] test-r-devdocs is failing to install rmarkdown
2 participants