-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36750: [R] Fix test-r-devdocs on MacOS #36751
Conversation
|
@github-actions crossbow submit test-r-devdocs |
Revision: 4c2c06a Submitted crossbow builds: ursacomputing/crossbow @ actions-ce18fdfab0
|
@github-actions crossbow submit test-r-devdocs |
Revision: 1d86763 Submitted crossbow builds: ursacomputing/crossbow @ actions-126f08892a
|
@github-actions crossbow submit test-r-devdocs |
Revision: 28df9f4 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c345aed07
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d98b3a1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing. ### What changes are included in this PR? Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both). ### Are these changes tested? Yes, as part of the test-r-devdocs job. ### Are there any user-facing changes? No. * Closes: apache#36750 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (apache#31757), so some of the package builds are failing. ### What changes are included in this PR? Use the `setup-r-dependencies` action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both). ### Are these changes tested? Yes, as part of the test-r-devdocs job. ### Are there any user-facing changes? No. * Closes: apache#36750 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
The test-r-devdocs job is failing. It is failing because we are pinning a version of R that is so old that CRAN no longer serves binaries (#31757), so some of the package builds are failing.
What changes are included in this PR?
Use the
setup-r-dependencies
action which either installs the correct build dependencies or uses older binary versions to avoid building from source (or both).Are these changes tested?
Yes, as part of the test-r-devdocs job.
Are there any user-facing changes?
No.