Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Doc][Python] Clarify behavior of pyarrow.compute.fill_value #35813

Merged
merged 2 commits into from
May 30, 2023

Conversation

spenczar
Copy link
Contributor

Discussed in #35624, particularly at #35624 (comment).

Doesn't close that issue, but it came up in discussion.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spenczar ! Just one nit.

python/pyarrow/compute.py Outdated Show resolved Hide resolved
@spenczar
Copy link
Contributor Author

Oops! Thanks for directly fixing it :)

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 30, 2023
@pitrou
Copy link
Member

pitrou commented May 30, 2023

CI failures are unrelated.

@pitrou pitrou merged commit e628ca5 into apache:main May 30, 2023
@spenczar spenczar deleted the fill_value_doc_tweak branch May 30, 2023 19:31
@ursabot
Copy link

ursabot commented May 31, 2023

Benchmark runs are scheduled for baseline = 2695293 and contender = e628ca5. e628ca5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.73% ⬆️0.12%] test-mac-arm
[Finished ⬇️2.29% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.08% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e628ca50 ec2-t3-xlarge-us-east-2
[Failed] e628ca50 test-mac-arm
[Finished] e628ca50 ursa-i9-9960x
[Finished] e628ca50 ursa-thinkcentre-m75q
[Finished] 26952930 ec2-t3-xlarge-us-east-2
[Failed] 26952930 test-mac-arm
[Finished] 26952930 ursa-i9-9960x
[Finished] 26952930 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants