-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed #35145
GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed #35145
Conversation
|
Thanks @westonpace - I found the same issue. I thought all tests passed before I merged it but I must have missed somehow. Thanks for fixing! |
They probably did all pass but they ran before #34904 was merged in. This kind of thing happens every so often when two PRs conflict with each other. |
Benchmark runs are scheduled for baseline = 2ba6628 and contender = d4f7332. d4f7332 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
… the aggregate node changed (apache#35145) ### Rationale for this change The unit test was broken by a recent change and needed to be updated. ### What changes are included in this PR? The unit test has been updated to expect the correct order. ### Are these changes tested? Yes ### Are there any user-facing changes? No * Closes: apache#35144 Authored-by: Weston Pace <[email protected]> Signed-off-by: Weston Pace <[email protected]>
Rationale for this change
The unit test was broken by a recent change and needed to be updated.
What changes are included in this PR?
The unit test has been updated to expect the correct order.
Are these changes tested?
Yes
Are there any user-facing changes?
No