ARROW-418: [C++] Array / Builder class code reorganization, flattening #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrow/types subdirectory Change-Id: I1d84f714b02a2e1abc0171663ca183b682be5907
xhochy
approved these changes
Dec 12, 2016
Change-Id: If499bab530929beed1e76e631a1512d44d8f4d62
Change-Id: I598cabec287f87f254b9d5d58f8cf0f0a81e8610
|
Did the status/buffer/memory-pool reorg too |
Change-Id: I5df4cfcb88e2db2c1b297c40bb43826cc5fe6945
Change-Id: I5a7f2c324c1252a880531a7589f8a4afc8d55c65
|
Here's the green build (from my fork): https://travis-ci.org/wesm/arrow/builds/183382590 |
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
See ARROW-33 patch apache#322 @xhochy this fails on Int96 timestamps. I'm not sure why yet Author: Wes McKinney <[email protected]> Closes apache#236 from wesm/PARQUET-866 and squashes the following commits: 4966fcb [Wes McKinney] Fix off-by-one error in int96 test case 5976d59 [Wes McKinney] Update Arrow version to head with ARROW-33 b1b69b9 [Wes McKinney] clang-format dfb2e2e [Wes McKinney] API fixes for ARROW-33 patch
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
See ARROW-33 patch apache#322 @xhochy this fails on Int96 timestamps. I'm not sure why yet Author: Wes McKinney <[email protected]> Closes apache#236 from wesm/PARQUET-866 and squashes the following commits: 4966fcb [Wes McKinney] Fix off-by-one error in int96 test case 5976d59 [Wes McKinney] Update Arrow version to head with ARROW-33 b1b69b9 [Wes McKinney] clang-format dfb2e2e [Wes McKinney] API fixes for ARROW-33 patch Change-Id: I16d3a3d51d806796eb4e56944139fa0cc2a64cab
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
See ARROW-33 patch apache#322 @xhochy this fails on Int96 timestamps. I'm not sure why yet Author: Wes McKinney <[email protected]> Closes apache#236 from wesm/PARQUET-866 and squashes the following commits: 4966fcb [Wes McKinney] Fix off-by-one error in int96 test case 5976d59 [Wes McKinney] Update Arrow version to head with ARROW-33 b1b69b9 [Wes McKinney] clang-format dfb2e2e [Wes McKinney] API fixes for ARROW-33 patch Change-Id: I16d3a3d51d806796eb4e56944139fa0cc2a64cab
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
See ARROW-33 patch apache#322 @xhochy this fails on Int96 timestamps. I'm not sure why yet Author: Wes McKinney <[email protected]> Closes apache#236 from wesm/PARQUET-866 and squashes the following commits: 4966fcb [Wes McKinney] Fix off-by-one error in int96 test case 5976d59 [Wes McKinney] Update Arrow version to head with ARROW-33 b1b69b9 [Wes McKinney] clang-format dfb2e2e [Wes McKinney] API fixes for ARROW-33 patch Change-Id: I16d3a3d51d806796eb4e56944139fa0cc2a64cab
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
See ARROW-33 patch apache#322 @xhochy this fails on Int96 timestamps. I'm not sure why yet Author: Wes McKinney <[email protected]> Closes apache#236 from wesm/PARQUET-866 and squashes the following commits: 4966fcb [Wes McKinney] Fix off-by-one error in int96 test case 5976d59 [Wes McKinney] Update Arrow version to head with ARROW-33 b1b69b9 [Wes McKinney] clang-format dfb2e2e [Wes McKinney] API fixes for ARROW-33 patch Change-Id: I16d3a3d51d806796eb4e56944139fa0cc2a64cab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been wanting to do this for a while -- it feels cleaner to me. I also am going to promote modules from arrow/util to the top level as well. I'm open to other ideas, too.