-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2657: [Python] Import TensorFlow python extension before pyarrow to avoid segfault #2210
Changes from all commits
1c9628f
7835fba
02cb500
57ca5fc
1135b51
ac38837
c18cccb
bbf6cfc
70f3bca
2ca3de9
92aef7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,13 @@ def parse_version(root): | |
__version__ = None | ||
|
||
|
||
import pyarrow.compat as compat | ||
|
||
|
||
# Workaround for https://issues.apache.org/jira/browse/ARROW-2657 | ||
compat.import_tensorflow_extension() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be run only on Linux? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, sorry I missed that (it was in the prior iteration of the patch but I didn't look closely enough at this function): https://issues.apache.org/jira/browse/ARROW-2795 |
||
|
||
|
||
from pyarrow.lib import cpu_count, set_cpu_count | ||
from pyarrow.lib import (null, bool_, | ||
int8, int16, int32, int64, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this test fail before this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried it on an ec2 instance before putting it in.