-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17787: [Java] Fix Javadoc build #14212
Conversation
* Don't document the javadocs to avoid errors when there is nothing documentable in the javadocs
@@ -688,7 +688,6 @@ | |||
<reportSet><!-- by default, id = "default" --> | |||
<reports><!-- select non-aggregate reports --> | |||
<report>javadoc</report> | |||
<report>test-javadoc</report> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidavidm just for my understanding: why this fixes the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc errors if it doesn't find any public classes to document, JUnit 5 means that test classes no longer need to be public, so the easiest solution is to just not document test code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks.
Benchmark runs are scheduled for baseline = 485128f and contender = bed6f8e. bed6f8e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Don't document the javadocs to avoid errors when there is nothing documentable in the javadocs Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Don't document the javadocs to avoid errors when there is nothing documentable in the javadocs Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Don't document the javadocs to avoid errors when there is nothing documentable in the javadocs