Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17659: [Java] Populate JDBC schema name metadata when config.shouldIncludeMetadata provided #14196

Merged
merged 1 commit into from
Sep 21, 2022
Merged

ARROW-17659: [Java] Populate JDBC schema name metadata when config.shouldIncludeMetadata provided #14196

merged 1 commit into from
Sep 21, 2022

Conversation

igor-suhorukov
Copy link
Contributor

Current implementation include catalog,table,column,type metadata, but schema metadata field is missing. In terms of PostgreSQL catalog - is database, schema - namespace inside database, so catalog name is insufficient for table addressing without schema.

Proposed changes is + metadata.put(Constants.SQL_SCHEMA_KEY, rsmd.getSchemaName(i));

@igor-suhorukov
Copy link
Contributor Author

Hello @lidavidm
Please look at this small changes. It should close JDBC metadata topic.

lidavidm
lidavidm approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17659

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm
Copy link
Member

Filed ARROW-17810 for JDK 18 test failure

@lidavidm lidavidm merged commit 43e66a9 into apache:master Sep 21, 2022
@ursabot
Copy link

ursabot commented Sep 22, 2022

Benchmark runs are scheduled for baseline = 2914325 and contender = 43e66a9. 43e66a9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.14% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 43e66a92 ec2-t3-xlarge-us-east-2
[Finished] 43e66a92 test-mac-arm
[Failed] 43e66a92 ursa-i9-9960x
[Finished] 43e66a92 ursa-thinkcentre-m75q
[Finished] 29143259 ec2-t3-xlarge-us-east-2
[Finished] 29143259 test-mac-arm
[Failed] 29143259 ursa-i9-9960x
[Finished] 29143259 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@igor-suhorukov @zagto
ARROW-17659: [Java] Populate JDBC schema name metadata when config.sh…
494ce62 
…ouldIncludeMetadata provided (apache#14196)

Current implementation include [catalog,table,column,type](https://github.com/apache/arrow/blob/master/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java#L248) metadata, but schema metadata field is missing. In terms of PostgreSQL catalog - is database, schema - namespace inside database, so catalog name is insufficient for table addressing without schema.

Proposed changes is + metadata.put(Constants.SQL_SCHEMA_KEY, rsmd.getSchemaName(i));

Authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@igor-suhorukov @fatemehp
ARROW-17659: [Java] Populate JDBC schema name metadata when config.sh…
75dfe77 
…ouldIncludeMetadata provided (apache#14196)

Current implementation include [catalog,table,column,type](https://github.com/apache/arrow/blob/master/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java#L248) metadata, but schema metadata field is missing. In terms of PostgreSQL catalog - is database, schema - namespace inside database, so catalog name is insufficient for table addressing without schema.

Proposed changes is + metadata.put(Constants.SQL_SCHEMA_KEY, rsmd.getSchemaName(i));

Authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-suhorukov @lidavidm @ursabot