Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17800: [C++] Fix failures in jemalloc stats tests #14194

Merged
merged 2 commits into from
Sep 21, 2022
Merged

ARROW-17800: [C++] Fix failures in jemalloc stats tests #14194

merged 2 commits into from
Sep 21, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Sep 21, 2022

  • Provide compatibility for 32-bit platforms
  • Avoid memory leak in tests
  • Make checks less strict

@pitrou
ARROW-17800: [C++] Fix failures in jemalloc stats tests
a0034b0 
- Provide compatibility for 32-bit platforms
- Avoid memory leak in tests
- Make checks less strict
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou pitrou requested a review from lidavidm September 21, 2022 16:44
@pitrou
Copy link
Member Author

pitrou commented Sep 21, 2022

cc @rok

rok
rok reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@rok rok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pitrou ! Too bad we can't reliably test these stats.

@pitrou
Copy link
Member Author

pitrou commented Sep 21, 2022

Revision: 01154d0

Submitted crossbow builds: ursacomputing/crossbow @ jemalloc-stats-1

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17800

@pitrou pitrou merged commit 2914325 into apache:master Sep 21, 2022
@pitrou pitrou deleted the ARROW-17800-jemalloc-stats-ci branch September 21, 2022 20:07
@rok
Copy link
Member

rok commented Sep 21, 2022

Thanks for fixing this @pitrou !

@ursabot
Copy link

ursabot commented Sep 22, 2022

Benchmark runs are scheduled for baseline = cf66aa0 and contender = 2914325. 2914325 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.2% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 29143259 ec2-t3-xlarge-us-east-2
[Finished] 29143259 test-mac-arm
[Failed] 29143259 ursa-i9-9960x
[Finished] 29143259 ursa-thinkcentre-m75q
[Finished] cf66aa03 ec2-t3-xlarge-us-east-2
[Finished] cf66aa03 test-mac-arm
[Failed] cf66aa03 ursa-i9-9960x
[Finished] cf66aa03 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou @zagto
ARROW-17800: [C++] Fix failures in jemalloc stats tests (apache#14194)
5a1ee0b 
- Provide compatibility for 32-bit platforms
- Avoid memory leak in tests
- Make checks less strict

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@pitrou @fatemehp
ARROW-17800: [C++] Fix failures in jemalloc stats tests (apache#14194)
b339a87 
- Provide compatibility for 32-bit platforms
- Avoid memory leak in tests
- Make checks less strict

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@asfimport asfimport mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rok rok rok approved these changes

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pitrou @rok @ursabot @lidavidm