Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java][CI] Fix grep for new nightlies versioning #14166

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Sep 19, 2022

I've noticed that the latest Java nightlies where not uploaded https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-c-data/. I missed to update the grep on this PR: #14135

I have now tested locally the bash script to validate the repo structure will now be generated correctly:

repo
└── org
    └── apache
        └── arrow
            ├── arrow-algorithm
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            ├── arrow-avro
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │       ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
...

@raulcd
Copy link
Member Author

raulcd commented Sep 19, 2022

@kou I missed to update this on the nightlies script, I've validated the Build Repository bash part of the nightly job locally now

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 081b70b into apache:master Sep 19, 2022
@ursabot
Copy link

ursabot commented Sep 19, 2022

Benchmark runs are scheduled for baseline = 59b5728 and contender = 081b70b. 081b70b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.41% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 081b70ba ec2-t3-xlarge-us-east-2
[Finished] 081b70ba test-mac-arm
[Failed] 081b70ba ursa-i9-9960x
[Finished] 081b70ba ursa-thinkcentre-m75q
[Finished] 59b57287 ec2-t3-xlarge-us-east-2
[Failed] 59b57287 test-mac-arm
[Failed] 59b57287 ursa-i9-9960x
[Finished] 59b57287 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
I've noticed that the latest Java nightlies where not uploaded https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-c-data/. I missed to update the grep on this PR: apache#14135

I have now tested locally the bash script to validate the repo structure will now be generated correctly:
```
repo
└── org
    └── apache
        └── arrow
            ├── arrow-algorithm
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            ├── arrow-avro
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │       ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
...
```

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
I've noticed that the latest Java nightlies where not uploaded https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-c-data/. I missed to update the grep on this PR: apache#14135

I have now tested locally the bash script to validate the repo structure will now be generated correctly:
```
repo
└── org
    └── apache
        └── arrow
            ├── arrow-algorithm
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT.pom
            │       ├── arrow-algorithm-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-algorithm-10.0.0-SNAPSHOT-tests.jar
            ├── arrow-avro
            │   ├── 10.0.0-SNAPSHOT
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │   │   ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │   │   └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
            │   └── 2022-09-18
            │       ├── arrow-avro-10.0.0-SNAPSHOT.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT-javadoc.jar
            │       ├── arrow-avro-10.0.0-SNAPSHOT.pom
            │       ├── arrow-avro-10.0.0-SNAPSHOT-sources.jar
            │       └── arrow-avro-10.0.0-SNAPSHOT-tests.jar
...
```

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants