Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17764: [CI][C++] "#include <optional>" is missing #14161

Merged
merged 1 commit into from
Sep 18, 2022
Merged

ARROW-17764: [CI][C++] "#include <optional>" is missing #14161

merged 1 commit into from
Sep 18, 2022

Conversation

kou
Copy link
Member

@kou kou commented Sep 17, 2022

https://github.com/ursacomputing/crossbow/actions/runs/3073442125/jobs/4965573117#step:5:8420

FAILED: src/arrow/flight/sql/CMakeFiles/arrow_flight_sql_objlib.dir/sql_info_internal.cc.o
/usr/bin/c++ .../arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc
In file included from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.h:20,
                 from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc:18:
/arrow/cpp/src/arrow/flight/sql/types.h:899:8: error: 'optional' in namespace 'std' does not name a template type
  899 |   std::optional<std::string> catalog;
      |        ^~~~~~~~
/arrow/cpp/src/arrow/flight/sql/types.h:29:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
   28 | #include "arrow/type_fwd.h"
  +++ |+#include <optional>
   29 |
/arrow/cpp/src/arrow/flight/sql/types.h:901:8: error: 'optional' in namespace 'std' does not name a template type
  901 |   std::optional<std::string> db_schema;
      |        ^~~~~~~~
/arrow/cpp/src/arrow/flight/sql/types.h:901:3: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
  901 |   std::optional<std::string> db_schema;
      |   ^~~

@kou
ARROW-17764: [CI][C++] "#include <optional>" is missing
2592668 
https://github.com/ursacomputing/crossbow/actions/runs/3073442125/jobs/4965573117#step:5:8420

    FAILED: src/arrow/flight/sql/CMakeFiles/arrow_flight_sql_objlib.dir/sql_info_internal.cc.o
    /usr/bin/c++ .../arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc
    In file included from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.h:20,
                     from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc:18:
    /arrow/cpp/src/arrow/flight/sql/types.h:899:8: error: 'optional' in namespace 'std' does not name a template type
      899 |   std::optional<std::string> catalog;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:29:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
       28 | #include "arrow/type_fwd.h"
      +++ |+#include <optional>
       29 |
    /arrow/cpp/src/arrow/flight/sql/types.h:901:8: error: 'optional' in namespace 'std' does not name a template type
      901 |   std::optional<std::string> db_schema;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:901:3: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
      901 |   std::optional<std::string> db_schema;
          |   ^~~
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17764

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Sep 17, 2022

@github-actions crossbow submit verify-rc-source-cpp-linux-ubuntu-22.04-amd64 verify-rc-source-ruby-linux-ubuntu-22.04-amd64

@github-actions
Copy link

Revision: 2592668

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e0081dcec

Task Status
verify-rc-source-cpp-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-ruby-linux-ubuntu-22.04-amd64 Github Actions

@kou kou merged commit 80676df into apache:master Sep 18, 2022
@kou kou deleted the cpp-optional-flight-sql branch September 18, 2022 00:45
@ursabot
Copy link

ursabot commented Sep 18, 2022

Benchmark runs are scheduled for baseline = 02b24f7 and contender = 80676df. 80676df is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.24% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 80676df0 ec2-t3-xlarge-us-east-2
[Finished] 80676df0 test-mac-arm
[Failed] 80676df0 ursa-i9-9960x
[Finished] 80676df0 ursa-thinkcentre-m75q
[Finished] 02b24f72 ec2-t3-xlarge-us-east-2
[Failed] 02b24f72 test-mac-arm
[Failed] 02b24f72 ursa-i9-9960x
[Finished] 02b24f72 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 18, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@kou @zagto
ARROW-17764: [CI][C++] "#include <optional>" is missing (apache#14161)
d427472 
https://github.com/ursacomputing/crossbow/actions/runs/3073442125/jobs/4965573117#step:5:8420

    FAILED: src/arrow/flight/sql/CMakeFiles/arrow_flight_sql_objlib.dir/sql_info_internal.cc.o
    /usr/bin/c++ .../arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc
    In file included from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.h:20,
                     from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc:18:
    /arrow/cpp/src/arrow/flight/sql/types.h:899:8: error: 'optional' in namespace 'std' does not name a template type
      899 |   std::optional<std::string> catalog;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:29:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
       28 | #include "arrow/type_fwd.h"
      +++ |+#include <optional>
       29 |
    /arrow/cpp/src/arrow/flight/sql/types.h:901:8: error: 'optional' in namespace 'std' does not name a template type
      901 |   std::optional<std::string> db_schema;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:901:3: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
      901 |   std::optional<std::string> db_schema;
          |   ^~~

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@kou @fatemehp
ARROW-17764: [CI][C++] "#include <optional>" is missing (apache#14161)
27792d7 
https://github.com/ursacomputing/crossbow/actions/runs/3073442125/jobs/4965573117#step:5:8420

    FAILED: src/arrow/flight/sql/CMakeFiles/arrow_flight_sql_objlib.dir/sql_info_internal.cc.o
    /usr/bin/c++ .../arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc
    In file included from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.h:20,
                     from /arrow/cpp/src/arrow/flight/sql/sql_info_internal.cc:18:
    /arrow/cpp/src/arrow/flight/sql/types.h:899:8: error: 'optional' in namespace 'std' does not name a template type
      899 |   std::optional<std::string> catalog;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:29:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
       28 | #include "arrow/type_fwd.h"
      +++ |+#include <optional>
       29 |
    /arrow/cpp/src/arrow/flight/sql/types.h:901:8: error: 'optional' in namespace 'std' does not name a template type
      901 |   std::optional<std::string> db_schema;
          |        ^~~~~~~~
    /arrow/cpp/src/arrow/flight/sql/types.h:901:3: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
      901 |   std::optional<std::string> db_schema;
          |   ^~~

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: FlightRPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kou @ursabot @lidavidm