Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17172: [C++][Python] test_cython_api fails on windows #14133

Merged
merged 5 commits into from
Sep 15, 2022
Merged

ARROW-17172: [C++][Python] test_cython_api fails on windows #14133

merged 5 commits into from
Sep 15, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Sep 15, 2022 •
edited
Loading

Tis PR adds CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1 to the AppVeyor setup to make test_cython.py succeed as the extension module being built fails loading in a subprocess otherwise.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17172

@AlenkaF AlenkaF marked this pull request as ready for review September 15, 2022 12:03
@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 15, 2022

I guess a suggestion from @jorisvandenbossche to use CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1 fixes AppVeyor failure also. The difference between the CI and the error I had locally is that in this case the importing failure happens in the subprocess for the extension module and locally I wasn't even able to run the tests or import pyarrow in the python console 🤷‍♀️

@pitrou what do you think?

pitrou
pitrou reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the principle

pitrou
pitrou reviewed Sep 15, 2022
View reviewed changes
@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 15, 2022

@pitrou I would merge this if you agree and the CI is green again.

@pitrou
Copy link
Member

pitrou commented Sep 15, 2022

Revision: 2628b61

Submitted crossbow builds: ursacomputing/crossbow @ conda-dll-search-0

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@pitrou
Copy link
Member

pitrou commented Sep 15, 2022

CI seems green @AlenkaF ;-)

@AlenkaF AlenkaF merged commit d8f64ee into apache:master Sep 15, 2022
@ursabot
Copy link

ursabot commented Sep 16, 2022

Benchmark runs are scheduled for baseline = e8aa1b9 and contender = d8f64ee. d8f64ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.1% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d8f64eec ec2-t3-xlarge-us-east-2
[Finished] d8f64eec test-mac-arm
[Failed] d8f64eec ursa-i9-9960x
[Finished] d8f64eec ursa-thinkcentre-m75q
[Finished] e8aa1b9b ec2-t3-xlarge-us-east-2
[Failed] e8aa1b9b test-mac-arm
[Failed] e8aa1b9b ursa-i9-9960x
[Finished] e8aa1b9b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF AlenkaF deleted the ARROW-17172 branch September 16, 2022 06:32
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@AlenkaF @zagto
ARROW-17172: [C++][Python] test_cython_api fails on windows (apache#1…
fde7853 
…4133)

Tis PR adds `CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1` to the AppVeyor setup to make `test_cython.py` succeed as the extension module being built fails loading in a subprocess otherwise.

Lead-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: Alenka Frim <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@AlenkaF @fatemehp
ARROW-17172: [C++][Python] test_cython_api fails on windows (apache#1…
2125f4d 
…4133)

Tis PR adds `CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1` to the AppVeyor setup to make `test_cython.py` succeed as the extension module being built fails loading in a subprocess otherwise.

Lead-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: Alenka Frim <[email protected]>
@asfimport asfimport mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlenkaF @pitrou @ursabot