-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17728: [C++][Gandiva] Accept LLVM 15.0 #14125
Conversation
|
There is another problem now: LLVM 15 adds dependency on zstd. It looks for target |
27a11e1
to
59372fe
Compare
It seems that the Zstd's official CMake package uses I'll push a change for it to this branch later. Please wait for a while... |
Is it a mandatory dependency? zstd shouldn't be required to write a JIT... |
The dependency can be avoided by turning LLVM_ENABLE_ZSTD off. But I'm a CMake newbie and not sure how to do it properly... |
Most probably, we must also accomodate for the fact that pre-built binary packages for LLVM probably have zstd enabled anyway. |
It seems that Gandiva with LLVM 15 have problems at least on MinGW. |
That is fine with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We can merge this after we can confirm new CI failures aren't increased with this.
"R / rhub/debian-gcc-devel:latest" is failed: https://github.com/apache/arrow/actions/runs/3063524875/jobs/4951928558#step:5:27585
("AMD64 Ubuntu 20.04 R 4.2 Force-Tests true" has the same failure.) But this will be solved by #14149. So I merge this. |
Benchmark runs are scheduled for baseline = 6bc2e01 and contender = 9131724. 9131724 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
Lead-authored-by: Jin Shang <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Lead-authored-by: Jin Shang <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
No description provided.