-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17701: [C++][Gandiva] Add support for untyped node #14110
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 7c7fbcf and contender = 78bfecf. 78bfecf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault. Other methods aren't affected because untyped nodes are only used inside the parser. Authored-by: Jin Shang <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault. Other methods aren't affected because untyped nodes are only used inside the parser. Authored-by: Jin Shang <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault.
Other methods aren't affected because untyped nodes are only used inside the parser.