Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17701: [C++][Gandiva] Add support for untyped node #14110

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented Sep 13, 2022

The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault.

Other methods aren't affected because untyped nodes are only used inside the parser.

@js8544 js8544 changed the title ARROW-17701: [C++][Gandiva]Add support for untyped node ARROW-17701: [C++][Gandiva] Add support for untyped node Sep 13, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 78bfecf into apache:master Sep 13, 2022
@ursabot
Copy link

ursabot commented Sep 14, 2022

Benchmark runs are scheduled for baseline = 7c7fbcf and contender = 78bfecf. 78bfecf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.49% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 78bfecf5 ec2-t3-xlarge-us-east-2
[Failed] 78bfecf5 test-mac-arm
[Failed] 78bfecf5 ursa-i9-9960x
[Finished] 78bfecf5 ursa-thinkcentre-m75q
[Finished] 7c7fbcfa ec2-t3-xlarge-us-east-2
[Failed] 7c7fbcfa test-mac-arm
[Failed] 7c7fbcfa ursa-i9-9960x
[Finished] 7c7fbcfa ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault.

Other methods aren't affected because untyped nodes are only used inside the parser.

Authored-by: Jin Shang <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@js8544 js8544 deleted the jinshang/gandiva/untyped_node branch October 11, 2022 08:42
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
The parser will first emit untyped literal and function nodes before type inference. We need to update the ToString method of Gandiva nodes to avoid seg fault.

Other methods aren't affected because untyped nodes are only used inside the parser.

Authored-by: Jin Shang <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants