ARROW-17703: [C++][Gandiva] Fix Gandiva OpenSSL dependency

[js8544]

If I build gandiva alone, I get a link error saying OpenSSL related definitions are not found. After some digging, I found out that ARROW_USE_OPENSSL is only turned on if any of the following conditions is met: PARQUET_REQUIRE_ENCRYPTION, ARROW_FLIGHT, ARROW_S3. Adding ARROW_GANDIVA to the list solves this issue.

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17703

[kou]

Could you remove find_package(OpenSSLAlt) in cpp/src/gandiva/CMakeLists.txt?

diff --git a/cpp/src/gandiva/CMakeLists.txt b/cpp/src/gandiva/CMakeLists.txt
index 3794b7a6c4..e69844d99a 100644
--- a/cpp/src/gandiva/CMakeLists.txt
+++ b/cpp/src/gandiva/CMakeLists.txt
@@ -40,8 +40,6 @@ endif()
 
 add_definitions(-DGANDIVA_LLVM_VERSION=${LLVM_VERSION_MAJOR})
 
-find_package(OpenSSLAlt REQUIRED)
-
 # Set the path where the bitcode file generated, see precompiled/CMakeLists.txt
 set(GANDIVA_PRECOMPILED_BC_PATH "${CMAKE_CURRENT_BINARY_DIR}/irhelpers.bc")
 set(GANDIVA_PRECOMPILED_CC_PATH "${CMAKE_CURRENT_BINARY_DIR}/precompiled_bitcode.cc")

[js8544]

Could you remove find_package(OpenSSLAlt) in cpp/src/gandiva/CMakeLists.txt?

diff --git a/cpp/src/gandiva/CMakeLists.txt b/cpp/src/gandiva/CMakeLists.txt
index 3794b7a6c4..e69844d99a 100644
--- a/cpp/src/gandiva/CMakeLists.txt
+++ b/cpp/src/gandiva/CMakeLists.txt
@@ -40,8 +40,6 @@ endif()
 
 add_definitions(-DGANDIVA_LLVM_VERSION=${LLVM_VERSION_MAJOR})
 
-find_package(OpenSSLAlt REQUIRED)
-
 # Set the path where the bitcode file generated, see precompiled/CMakeLists.txt
 set(GANDIVA_PRECOMPILED_BC_PATH "${CMAKE_CURRENT_BINARY_DIR}/irhelpers.bc")
 set(GANDIVA_PRECOMPILED_CC_PATH "${CMAKE_CURRENT_BINARY_DIR}/precompiled_bitcode.cc")

done

[kou]

+1

[ursabot]

Benchmark runs are scheduled for baseline = 01dce6a and contender = 7c7fbcf. 7c7fbcf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.53% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7c7fbcfa ec2-t3-xlarge-us-east-2
[Failed] 7c7fbcfa test-mac-arm
[Failed] 7c7fbcfa ursa-i9-9960x
[Finished] 7c7fbcfa ursa-thinkcentre-m75q
[Finished] 01dce6a0 ec2-t3-xlarge-us-east-2
[Finished] 01dce6a0 test-mac-arm
[Failed] 01dce6a0 ursa-i9-9960x
[Finished] 01dce6a0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java