ARROW-17694: [C++] Remove std::optional backport #14105
Conversation
pitrou
force-pushed
the
ARROW-17694-std-optional
branch
from
d0bdb0b to
9168b04
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
|
pitrou
force-pushed
the
ARROW-17694-std-optional
branch
from
0809adb to
5bd1967
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@assignUser Would you know how to change the macOS deployment target for autobrew? I tried to set it to 10.14 using the env var |
|
Not of the bat, I'll look into it. I hope it is possible otherwise that might be an issue due to CRAN building on 10.13. |
|
The envvar is correctly set in the wf and looking at our cmake it should get picked up. I wonder if the issue is that the deployment target can't be higher than the host? I haven't found anything documenting such behavior and the llvm/clang version installed should support c++17 (as we confirmed previously). I also had a glance at autobrew and I don't think it is forcing the deployment target anywhere. Maybe passing it explicitly as a cmake arg in the formula works? https://github.com/pitrou/arrow/blob/ARROW-17694-std-optional/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb |
This comment was marked as outdated.
This comment was marked as outdated.
|
@assignUser Well, it got even worse as there's now an error about something being available only in 10.12+: Yet as you can see the correct compiler command-line options seem to be given... I can only assume that homebrew is doing something horrible under the hood :-( |
|
Revision: 93f4f3e Submitted crossbow builds: ursacomputing/crossbow @ optional-4
|
|
I looked at some other packages on CRAN using C++17 and found that httpgd uses I'll check their configure/autobrew script |
pitrou
force-pushed
the
ARROW-17694-std-optional
branch
from
93f4f3e to
a184425
Compare
|
Revision: a184425 Submitted crossbow builds: ursacomputing/crossbow @ optional-5
|
|
That looks promising 🤞 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@kou Would you mind giving this another look? |
| @@ -42,6 +42,7 @@ class ApacheArrow < Formula | |||
| def install | |||
| ENV.cxx11 | |||
| args = %W[ | |||
| -DARROW_CXXFLAGS="-D_LIBCPP_DISABLE_AVAILABILITY" | |||
There was a problem hiding this comment.
Could you put this after -DARROW_CSV=ON to keep order?
Just use the C++17 standard library version.
pitrou
force-pushed
the
ARROW-17694-std-optional
branch
from
4941806 to
3566dee
Compare
|
Revision: 3566dee Submitted crossbow builds: ursacomputing/crossbow @ optional-7
|
|
The test failures seem the same as usual, so I'm going to merge. |
|
Benchmark runs are scheduled for baseline = 2749fef and contender = 5e49174. 5e49174 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Just use the C++17 standard library version. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Just use the C++17 standard library version. Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Just use the C++17 standard library version.