Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17674: [R] Implement dplyr::across() inside arrange() #14092

Merged
merged 3 commits into from
Sep 12, 2022
Merged

ARROW-17674: [R] Implement dplyr::across() inside arrange() #14092

merged 3 commits into from
Sep 12, 2022

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 10, 2022

No description provided.

@eitsupi
Implement dplyr::across() inside arrange()
6651b75 
Signed-off-by: SHIMA Tatsuya <[email protected]>
@eitsupi
add tests
3667337 
Signed-off-by: SHIMA Tatsuya <[email protected]>
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-11699

@eitsupi eitsupi changed the title ARROW-11699: [R] Implement dplyr::across() inside arrange() ARROW-17674: [R] Implement dplyr::across() inside arrange() Sep 10, 2022
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17674

nealrichardson
nealrichardson reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One question about a possible simplification

r/R/dplyr-arrange.R Outdated Show resolved Hide resolved
@eitsupi
remove unused lines
0cf7585 
Signed-off-by: SHIMA Tatsuya <[email protected]>
nealrichardson
nealrichardson approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nealrichardson nealrichardson merged commit 05b7fe3 into apache:master Sep 12, 2022
@eitsupi eitsupi deleted the r-arrange-across branch September 12, 2022 15:17
@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 12, 2022

Thank you for merging this.
I hope you see #14090 and #14091 as they relate to this.

@ursabot
Copy link

ursabot commented Sep 13, 2022

Benchmark runs are scheduled for baseline = ea382af and contender = 05b7fe3. 05b7fe3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.51% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 05b7fe35 ec2-t3-xlarge-us-east-2
[Failed] 05b7fe35 test-mac-arm
[Failed] 05b7fe35 ursa-i9-9960x
[Finished] 05b7fe35 ursa-thinkcentre-m75q
[Finished] ea382af7 ec2-t3-xlarge-us-east-2
[Finished] ea382af7 test-mac-arm
[Failed] ea382af7 ursa-i9-9960x
[Finished] ea382af7 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@eitsupi @zagto
ARROW-17674: [R] Implement dplyr::across() inside arrange() (apache#1…
77d6f89 
…4092)

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Neal Richardson <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@eitsupi @fatemehp
ARROW-17674: [R] Implement dplyr::across() inside arrange() (apache#1…
5fa8ef1 
…4092)

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Neal Richardson <[email protected]>
This was referenced Sep 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eitsupi @ursabot @nealrichardson