Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16870: [C++] Fix link issues with ldd and clang for flight examples #14077

Conversation

aucahuasi
Copy link
Contributor

@aucahuasi aucahuasi commented Sep 8, 2022

It seems ldd doesn't like this flag --no-as-needed, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that.
I was able to build the arrow flight example and run without issues:
./flight-grpc-example -port 8086
Notes:

clang++ --version
Apple clang version 14.0.0 (clang-1400.0.29.102)

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cpp/examples/arrow/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/examples/arrow/CMakeLists.txt Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@aucahuasi
Copy link
Contributor Author

@lidavidm Thanks for reviewing this, out of curiosity: do I need to enable the option to build the arrow examples for macOS (-DARROW_BUILD_EXAMPLES=ON, currently is OFF)? perhaps there are some files I need to update here:
https://github.com/apache/arrow/tree/master/ci

@lidavidm
Copy link
Member

lidavidm commented Sep 8, 2022

I suppose this job could have it enabled, not sure why it isn't:

@aucahuasi aucahuasi force-pushed the ARROW-16870-fix-ldd-issue-clang-flight-examples branch from 1b643e6 to 2b6f6ce Compare September 9, 2022 16:41
@aucahuasi
Copy link
Contributor Author

It seems the CI job that is failing is also affecting other PRs.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm
Copy link
Member

Indeed, we're trying to fix up the CI, but this fix is fine

@lidavidm lidavidm merged commit efb7fb0 into apache:master Sep 12, 2022
@ursabot
Copy link

ursabot commented Sep 12, 2022

Benchmark runs are scheduled for baseline = 75d2bfd and contender = efb7fb0. efb7fb0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.28% ⬆️0.56%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] efb7fb08 ec2-t3-xlarge-us-east-2
[Failed] efb7fb08 test-mac-arm
[Failed] efb7fb08 ursa-i9-9960x
[Finished] efb7fb08 ursa-thinkcentre-m75q
[Finished] 75d2bfd3 ec2-t3-xlarge-us-east-2
[Failed] 75d2bfd3 test-mac-arm
[Failed] 75d2bfd3 ursa-i9-9960x
[Finished] 75d2bfd3 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…ples (apache#14077)

It seems `ldd` doesn't like this flag `--no-as-needed`, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that.
I was able to build the arrow flight example and run without issues:
`./flight-grpc-example -port 8086`
Notes:
```bash
clang++ --version
Apple clang version 14.0.0 (clang-1400.0.29.102)
```

Authored-by: Percy Camilo Triveño Aucahuasi <[email protected]>
Signed-off-by: David Li <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…ples (apache#14077)

It seems `ldd` doesn't like this flag `--no-as-needed`, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that.
I was able to build the arrow flight example and run without issues:
`./flight-grpc-example -port 8086`
Notes:
```bash
clang++ --version
Apple clang version 14.0.0 (clang-1400.0.29.102)
```

Authored-by: Percy Camilo Triveño Aucahuasi <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants