-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16870: [C++] Fix link issues with ldd and clang for flight examples #14077
ARROW-16870: [C++] Fix link issues with ldd and clang for flight examples #14077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@lidavidm Thanks for reviewing this, out of curiosity: do I need to enable the option to build the arrow examples for macOS ( |
I suppose this job could have it enabled, not sure why it isn't: arrow/.github/workflows/cpp.yml Line 121 in 99b57e8
|
remove unnecessary linker flags
1b643e6
to
2b6f6ce
Compare
It seems the CI job that is failing is also affecting other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Indeed, we're trying to fix up the CI, but this fix is fine |
Benchmark runs are scheduled for baseline = 75d2bfd and contender = efb7fb0. efb7fb0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ples (apache#14077) It seems `ldd` doesn't like this flag `--no-as-needed`, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that. I was able to build the arrow flight example and run without issues: `./flight-grpc-example -port 8086` Notes: ```bash clang++ --version Apple clang version 14.0.0 (clang-1400.0.29.102) ``` Authored-by: Percy Camilo Triveño Aucahuasi <[email protected]> Signed-off-by: David Li <[email protected]>
…ples (apache#14077) It seems `ldd` doesn't like this flag `--no-as-needed`, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that. I was able to build the arrow flight example and run without issues: `./flight-grpc-example -port 8086` Notes: ```bash clang++ --version Apple clang version 14.0.0 (clang-1400.0.29.102) ``` Authored-by: Percy Camilo Triveño Aucahuasi <[email protected]> Signed-off-by: David Li <[email protected]>
It seems
ldd
doesn't like this flag--no-as-needed
, so the arrow flight example cannot build on macOS with clang. This minor PR tries to fix that.I was able to build the arrow flight example and run without issues:
./flight-grpc-example -port 8086
Notes: