ARROW-17579: [Python] PYARROW_CXXFLAGS ignored?

[AlenkaF]

This PR adds:

• PYARROW_CXXFLAGS variable to PyArrow C++ and Pyarrow cmake builds (both defined in setup.py)
• a common flags section to pyarrow/src/CMakeLists.txt where CXX_COMMON_FLAGS and PYARROW_CXXFLAGS are added to the CMAKE_CXX_FLAGS variable.

Other flags defined in Arrow C++ should be included in PyArrow C++ and PyArrow with include(SetupCxxFlags).

I am not sure if additional flags that are defined in PyArrow, see:

arrow/python/CMakeLists.txt

Lines 134 to 174 in 43670af

	if(MSVC)
	# MSVC version of -Wno-return-type-c-linkage
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4190")
	# Cython generates some bitshift expressions that MSVC does not like in
	# __Pyx_PyFloat_DivideObjC
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4293")
	# Converting to/from C++ bool is pretty wonky in Cython. The C4800 warning
	# seem harmless, and probably not worth the effort of working around it
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4800")
	# See https://github.com/cython/cython/issues/2731. Change introduced in
	# Cython 0.29.1 causes "unsafe use of type 'bool' in operation"
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4804")
	else()
	# Enable perf and other tools to work properly
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-omit-frame-pointer")
	# Suppress Cython warnings
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-variable -Wno-maybe-uninitialized")
	if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID STREQUAL
	"Clang")
	# Cython warnings in clang
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-parentheses-equality")
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-constant-logical-operand")
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-declarations")
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-sometimes-uninitialized")
	# We have public Cython APIs which return C++ types, which are in an extern
	# "C" blog (no symbol mangling) and clang doesn't like this
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-return-type-c-linkage")
	endif()
	endif()
	# For any C code, use the same flags.
	set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS}")
	# Add C++-only flags, like -std=c++11
	set(CMAKE_CXX_FLAGS "${CXX_ONLY_FLAGS} ${CMAKE_CXX_FLAGS}")

are needed in PyArrow C++ as they were not used when PyArrow C++ was included in Arrow C++?
cc @pitrou

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17579

[pitrou]

@AlenkaF You might try this patch to fix the AppVeyor error:

diff --git a/python/pyarrow/_compute.pyx b/python/pyarrow/_compute.pyx
index b9594d90e..2aa65e75c 100644
--- a/python/pyarrow/_compute.pyx
+++ b/python/pyarrow/_compute.pyx
@@ -2613,7 +2613,7 @@ def register_scalar_function(func, function_name, function_doc, in_types,
         raise TypeError(
             "in_types must be a dictionary of DataType")
 
-    c_arity = CArity(num_args, func_spec.varargs)
+    c_arity = CArity(<int> num_args, func_spec.varargs)
 
     if "summary" not in function_doc:
         raise ValueError("Function doc must contain a summary")

[kou]

+1

[AlenkaF]

@pitrou I have added the suggestions and will merge this PR later today if there is no objection.

Note: Travis issue has a JIRA already.

[ursabot]

Benchmark runs are scheduled for baseline = 81f3945 and contender = 9c628b7. 9c628b7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.24% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9c628b70 ec2-t3-xlarge-us-east-2
[Finished] 9c628b70 test-mac-arm
[Failed] 9c628b70 ursa-i9-9960x
[Finished] 9c628b70 ursa-thinkcentre-m75q
[Finished] 81f3945d ec2-t3-xlarge-us-east-2
[Failed] 81f3945d test-mac-arm
[Failed] 81f3945d ursa-i9-9960x
[Finished] 81f3945d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[ursabot]

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm