Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17600: [Go] Implement Casting for Nested types #14056

Merged
merged 4 commits into from
Sep 7, 2022
Merged

ARROW-17600: [Go] Implement Casting for Nested types #14056

merged 4 commits into from
Sep 7, 2022

Conversation

zeroshade
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

https://issues.apache.org/jira/browse/ARROW-17600

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm approved these changes Sep 7, 2022
View reviewed changes
ci/scripts/go_test.sh
@@ -19,12 +19,20 @@

set -ex

# simplistic semver comparison
verlte() {
[ "$1" = "`echo -e "$1\n$2" | sort -V | head -n1`" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

go/arrow/array/struct.go Show resolved Hide resolved
go/arrow/datatype.go Show resolved Hide resolved
@zeroshade zeroshade merged commit d123277 into apache:master Sep 7, 2022
@zeroshade zeroshade deleted the arrow-17600-cast-nested branch September 7, 2022 21:32
drin pushed a commit to drin/arrow that referenced this pull request Sep 7, 2022
@zeroshade @drin
ARROW-17600: [Go] Implement Casting for Nested types (apache#14056)
6decedb 
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
@ursabot
Copy link

ursabot commented Sep 8, 2022

Benchmark runs are scheduled for baseline = 21491ec and contender = d123277. d123277 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.1% ⬆️0.0%] test-mac-arm
[Failed ⬇️1.1% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d123277b ec2-t3-xlarge-us-east-2
[Finished] d123277b test-mac-arm
[Failed] d123277b ursa-i9-9960x
[Finished] d123277b ursa-thinkcentre-m75q
[Finished] 21491ec0 ec2-t3-xlarge-us-east-2
[Finished] 21491ec0 test-mac-arm
[Failed] 21491ec0 ursa-i9-9960x
[Finished] 21491ec0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@zeroshade @zagto
ARROW-17600: [Go] Implement Casting for Nested types (apache#14056)
4c96ebb 
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@zeroshade @fatemehp
ARROW-17600: [Go] Implement Casting for Nested types (apache#14056)
cab1328 
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@cyb70289 cyb70289 Awaiting requested review from cyb70289

Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroshade @ursabot @lidavidm