Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Ruby] Fix wrong English #14046

Merged
merged 2 commits into from
Sep 6, 2022
Merged

MINOR: [Ruby] Fix wrong English #14046

merged 2 commits into from
Sep 6, 2022

Conversation

wilhelmagren
Copy link
Contributor

Change "There are the [...]" to "These are the [...]". Incorrect wording in previous README.

Change "There are the [...]" to "These are the [...]",  incorrect wording in previous README.
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@wilhelmagren wilhelmagren changed the title Update readme with correct wording. MINOR: [ruby/README.md] Update readme with correct wording. Sep 5, 2022
ruby/README.md Outdated Show resolved Hide resolved
@kou kou changed the title MINOR: [ruby/README.md] Update readme with correct wording. MINOR: [Ruby] Fix wrong English Sep 6, 2022
Co-authored-by: Sutou Kouhei <[email protected]>
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 23c5cee into apache:master Sep 6, 2022
@ursabot
Copy link

ursabot commented Sep 6, 2022

Benchmark runs are scheduled for baseline = 7a0ba80 and contender = 23c5cee. 23c5cee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 23c5ceea ec2-t3-xlarge-us-east-2
[Failed] 23c5ceea test-mac-arm
[Failed] 23c5ceea ursa-i9-9960x
[Finished] 23c5ceea ursa-thinkcentre-m75q
[Finished] 7a0ba807 ec2-t3-xlarge-us-east-2
[Failed] 7a0ba807 test-mac-arm
[Failed] 7a0ba807 ursa-i9-9960x
[Finished] 7a0ba807 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Sep 6, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

drin pushed a commit to drin/arrow that referenced this pull request Sep 7, 2022
Change "There are the [...]" to "These are the [...]". Incorrect wording in previous README.

Authored-by: Wilhelm Ågren <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Change "There are the [...]" to "These are the [...]". Incorrect wording in previous README.

Authored-by: Wilhelm Ågren <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
Change "There are the [...]" to "These are the [...]". Incorrect wording in previous README.

Authored-by: Wilhelm Ågren <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants