Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17586: [Go] String To Numeric cast functions #14015

Merged
merged 2 commits into from
Sep 1, 2022
Merged

ARROW-17586: [Go] String To Numeric cast functions #14015

merged 2 commits into from
Sep 1, 2022

Conversation

zeroshade
Copy link
Member

No description provided.

@zeroshade zeroshade requested review from lidavidm and cyb70289 August 31, 2022 17:30
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17586

cyb70289
cyb70289 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/arrow/compute/cast_test.go
Comment on lines +1298 to +1299
datum := compute.NewDatum(arr)
defer datum.Release()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this pattern often. Not familiar with go arrow implementation. Just curious why we need to release things explicitly. What release does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The primary Arrow docs explain this: https://github.com/apache/arrow/tree/master/go#reference-counting

Essentially the objects utilize reference counting to know when it can eagerly release buffers and re-use objects / memory (particularly with custom Allocators)

@zeroshade zeroshade merged commit fea7cc3 into apache:master Sep 1, 2022
@zeroshade zeroshade deleted the arrow-17586-string-numeric branch September 1, 2022 18:01
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = 5d0ed86 and contender = fea7cc3. fea7cc3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.71% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] fea7cc3a ec2-t3-xlarge-us-east-2
[Failed] fea7cc3a test-mac-arm
[Failed] fea7cc3a ursa-i9-9960x
[Finished] fea7cc3a ursa-thinkcentre-m75q
[Finished] 5d0ed864 ec2-t3-xlarge-us-east-2
[Failed] 5d0ed864 test-mac-arm
[Failed] 5d0ed864 ursa-i9-9960x
[Finished] 5d0ed864 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@zeroshade @zagto
ARROW-17586: [Go] String To Numeric cast functions (apache#14015)
e2cf223 
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@zeroshade @fatemehp
ARROW-17586: [Go] String To Numeric cast functions (apache#14015)
1a88ee7 
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroshade @ursabot @cyb70289