Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17571: [Benchmarks] Default build for PyArrow seems to be debug #14010

Merged
merged 2 commits into from
Sep 1, 2022
Merged

ARROW-17571: [Benchmarks] Default build for PyArrow seems to be debug #14010

merged 2 commits into from
Sep 1, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Aug 31, 2022

This PR tries to change PyArrow to be built in release and not in debug mode for Benchmarks builds.

@AlenkaF
Copy link
Member Author

AlenkaF commented Aug 31, 2022

@ursabot please benchmark name=file-write lang=Python

@ursabot
Copy link

ursabot commented Aug 31, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = cf27001 and contender = 641434c. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on test-mac-arm] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Skipped ⚠️ Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 641434c9 ursa-i9-9960x
[Finished] cf27001d ec2-t3-xlarge-us-east-2
[Failed] cf27001d test-mac-arm
[Failed] cf27001d ursa-i9-9960x
[Finished] cf27001d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17571

@AlenkaF
Copy link
Member Author

AlenkaF commented Aug 31, 2022

@ursabot please benchmark name=file-read lang=Python

@ursabot
Copy link

ursabot commented Aug 31, 2022

Commit 641434c already has scheduled benchmark runs.

@pitrou
Copy link
Member

pitrou commented Aug 31, 2022

Ok, so the "CMake for PyArrow C++" step seems to run in DEBUG mode on master but in RELEASE mode on this PR.

This is with the caveat that I had to compare two different benchmarking configurations, since some have failed.

@AlenkaF
Copy link
Member Author

AlenkaF commented Aug 31, 2022

If I understand correctly you are confirming this PR makes the correct change in the Benchmark build?

@pitrou
Copy link
Member

pitrou commented Aug 31, 2022

If I understand correctly you are confirming this PR makes the correct change in the Benchmark build?

Yes :-)

@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 1, 2022

Will rebase and run another benchmark, just to be sure. After that I would merge this PR, if there is no objection.

@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 1, 2022

@ursabot please benchmark name=dataframe-to-table lang=Python

@ursabot
Copy link

ursabot commented Sep 1, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = d3d6371 and contender = e6581fc. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on test-mac-arm] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Skipped ⚠️ Only ['C++', 'Java'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e6581fc6 ursa-i9-9960x
[Finished] d3d6371e ec2-t3-xlarge-us-east-2
[Failed] d3d6371e test-mac-arm
[Failed] d3d6371e ursa-i9-9960x
[Finished] d3d6371e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@AlenkaF
Copy link
Member Author

AlenkaF commented Sep 1, 2022

The benchmarks look good, there is no objection so I will merge the PR.

@AlenkaF AlenkaF merged commit c60fd42 into apache:master Sep 1, 2022
@AlenkaF AlenkaF deleted the ARROW-17571 branch September 1, 2022 14:59
@ursabot
Copy link

ursabot commented Sep 1, 2022

Benchmark runs are scheduled for baseline = 91aeae8 and contender = c60fd42. c60fd42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.46% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c60fd424 ec2-t3-xlarge-us-east-2
[Failed] c60fd424 test-mac-arm
[Failed] c60fd424 ursa-i9-9960x
[Finished] c60fd424 ursa-thinkcentre-m75q
[Finished] 91aeae8c ec2-t3-xlarge-us-east-2
[Failed] 91aeae8c test-mac-arm
[Failed] 91aeae8c ursa-i9-9960x
[Finished] 91aeae8c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@AlenkaF @zagto
ARROW-17571: [Benchmarks] Default build for PyArrow seems to be debug (…
4ac3aea 
…apache#14010)

This PR tries to change PyArrow to be built in release and not in debug mode for Benchmarks builds.

Authored-by: Alenka Frim <[email protected]>
Signed-off-by: Alenka Frim <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@AlenkaF @fatemehp
ARROW-17571: [Benchmarks] Default build for PyArrow seems to be debug (…
61c40a4 
…apache#14010)

This PR tries to change PyArrow to be built in release and not in debug mode for Benchmarks builds.

Authored-by: Alenka Frim <[email protected]>
Signed-off-by: Alenka Frim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlenkaF @ursabot @pitrou