ARROW-17565: [C++] Backward compatible ${PACKAGE}_shared CMake target isn't provided #14003
Conversation
… isn't provided This is a follow-up of ARROW-12175 / apache#13892 . We introduced `${PACKAGE}::` namespace to all exported CMake targets such as `Arrow::arrow_shared` and `Arrow::arrow_static` but we also provides no namespaced CMake targets such as `arrow_share` and `arrow_static` as aliases of namespaced CMake targets. But the backward compatibility feature isn't worked for `_shared`.
|
|
|
@kou Can you update https://github.com/apache/arrow/blob/master/docs/source/cpp/build_system.rst (either in this PR or as a separate JIRA)? |
|
Sure. Sorry for missing the doc task. I'll do it as a separated task (ARROW-17575) because reusing ARROW-17565 for document isn't suitable. So I merge this. |
|
Benchmark runs are scheduled for baseline = 359eab5 and contender = 5be95c7. 5be95c7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
… isn't provided (apache#14003) This is a follow-up of ARROW-12175 / apache#13892 . We introduced `${PACKAGE}::` namespace to all exported CMake targets such as `Arrow::arrow_shared` and `Arrow::arrow_static`, but we also provided no-namespaced CMake targets such as `arrow_shared` and `arrow_static` as aliases of namespaced CMake targets. However, the logic to provide `arrow_shared` was buggy. Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
… isn't provided (apache#14003) This is a follow-up of ARROW-12175 / apache#13892 . We introduced `${PACKAGE}::` namespace to all exported CMake targets such as `Arrow::arrow_shared` and `Arrow::arrow_static`, but we also provided no-namespaced CMake targets such as `arrow_shared` and `arrow_static` as aliases of namespaced CMake targets. However, the logic to provide `arrow_shared` was buggy. Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
… isn't provided (apache#14003) This is a follow-up of ARROW-12175 / apache#13892 . We introduced `${PACKAGE}::` namespace to all exported CMake targets such as `Arrow::arrow_shared` and `Arrow::arrow_static`, but we also provided no-namespaced CMake targets such as `arrow_shared` and `arrow_static` as aliases of namespaced CMake targets. However, the logic to provide `arrow_shared` was buggy. Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This is a follow-up of ARROW-12175 / #13892 .
We introduced
${PACKAGE}::namespace to all exported CMake targetssuch as
Arrow::arrow_sharedandArrow::arrow_static, but we alsoprovided no-namespaced CMake targets such as
arrow_sharedandarrow_staticas aliases of namespaced CMake targets.However, the logic to provide
arrow_sharedwas buggy.