Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Ruby] Fixed credential information of ClickHouse API #13999

Merged
merged 1 commit into from
Aug 30, 2022
Merged

MINOR: [Ruby] Fixed credential information of ClickHouse API #13999

merged 1 commit into from
Aug 30, 2022

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Aug 30, 2022

What I did

What I checked

  • I ran the command in my local environment.
# red-arrow.rb
params = {
  query: "SELECT WatchID as watch FROM hits LIMIT 10 FORMAT Arrow",
  user: "play",
  password: "",
  database: "default"
}
uri = URI('https://play.clickhouse.com:443/')
uri.query = URI.encode_www_form(params)
resp = Net::HTTP.get(uri)
table = Arrow::Table.load(Arrow::Buffer.new(resp))
p table
% ruby red-arrow.rb
#<Arrow::Table:0x11f8e0c18 ptr=0x11f6dced0>
                      watch
 0      8120543446287442873
 1      9110818468285196899
 2      8156744413230856864
 3      5206346422301499756
 4      6308646140879811077
 5      6635790769678439148
 6      4894690465724379622
 7      6864353419233967042
 8      8740403056911509777
 9      8924809397503602651

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@otegami otegami changed the title MINOR: [Ruby] Fixed credential information of ClickHouse API MINOR: [Ruby] Fixed credential information of ClickHouse API Aug 30, 2022
@otegami otegami marked this pull request as ready for review August 30, 2022 00:59
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Good catch!

@kou kou merged commit 15d6959 into apache:master Aug 30, 2022
@otegami otegami deleted the fix-red-arrow-readme branch August 30, 2022 01:16
@ursabot
Copy link

ursabot commented Aug 30, 2022

Benchmark runs are scheduled for baseline = 9f2a4b0 and contender = 15d6959. 15d6959 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 15d69596 ec2-t3-xlarge-us-east-2
[Failed] 15d69596 test-mac-arm
[Failed] 15d69596 ursa-i9-9960x
[Finished] 15d69596 ursa-thinkcentre-m75q
[Finished] 9f2a4b0b ec2-t3-xlarge-us-east-2
[Failed] 9f2a4b0b test-mac-arm
[Failed] 9f2a4b0b ursa-i9-9960x
[Finished] 9f2a4b0b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
…13999)

## What I did
- Fixed credential information of ClickHouse API at README.md
    - Latest Information was changed
    - https://clickhouse.com/docs/ru/getting-started/playground/

## What I checked
- I ran the command in my local environment.

```ruby
# red-arrow.rb
params = {
  query: "SELECT WatchID as watch FROM hits LIMIT 10 FORMAT Arrow",
  user: "play",
  password: "",
  database: "default"
}
uri = URI('https://play.clickhouse.com:443/')
uri.query = URI.encode_www_form(params)
resp = Net::HTTP.get(uri)
table = Arrow::Table.load(Arrow::Buffer.new(resp))
p table
```
```console
% ruby red-arrow.rb
#<Arrow::Table:0x11f8e0c18 ptr=0x11f6dced0>
                      watch
 0      8120543446287442873
 1      9110818468285196899
 2      8156744413230856864
 3      5206346422301499756
 4      6308646140879811077
 5      6635790769678439148
 6      4894690465724379622
 7      6864353419233967042
 8      8740403056911509777
 9      8924809397503602651
```

Authored-by: otegami <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…13999)

## What I did
- Fixed credential information of ClickHouse API at README.md
    - Latest Information was changed
    - https://clickhouse.com/docs/ru/getting-started/playground/

## What I checked
- I ran the command in my local environment.

```ruby
# red-arrow.rb
params = {
  query: "SELECT WatchID as watch FROM hits LIMIT 10 FORMAT Arrow",
  user: "play",
  password: "",
  database: "default"
}
uri = URI('https://play.clickhouse.com:443/')
uri.query = URI.encode_www_form(params)
resp = Net::HTTP.get(uri)
table = Arrow::Table.load(Arrow::Buffer.new(resp))
p table
```
```console
% ruby red-arrow.rb
#<Arrow::Table:0x11f8e0c18 ptr=0x11f6dced0>
                      watch
 0      8120543446287442873
 1      9110818468285196899
 2      8156744413230856864
 3      5206346422301499756
 4      6308646140879811077
 5      6635790769678439148
 6      4894690465724379622
 7      6864353419233967042
 8      8740403056911509777
 9      8924809397503602651
```

Authored-by: otegami <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…13999)

## What I did
- Fixed credential information of ClickHouse API at README.md
    - Latest Information was changed
    - https://clickhouse.com/docs/ru/getting-started/playground/

## What I checked
- I ran the command in my local environment.

```ruby
# red-arrow.rb
params = {
  query: "SELECT WatchID as watch FROM hits LIMIT 10 FORMAT Arrow",
  user: "play",
  password: "",
  database: "default"
}
uri = URI('https://play.clickhouse.com:443/')
uri.query = URI.encode_www_form(params)
resp = Net::HTTP.get(uri)
table = Arrow::Table.load(Arrow::Buffer.new(resp))
p table
```
```console
% ruby red-arrow.rb
#<Arrow::Table:0x11f8e0c18 ptr=0x11f6dced0>
                      watch
 0      8120543446287442873
 1      9110818468285196899
 2      8156744413230856864
 3      5206346422301499756
 4      6308646140879811077
 5      6635790769678439148
 6      4894690465724379622
 7      6864353419233967042
 8      8740403056911509777
 9      8924809397503602651
```

Authored-by: otegami <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants