-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17553: [Go] Enable flight.Server to register additional grpc services #13995
Conversation
@jiezhang Thanks for the contribution, could you add a test for this? |
4a2860e
to
5449dd5
Compare
@zeroshade I added a unit test. Can you please take another look? |
|
Looks good to me, once all the checks succeed i'll merge it :) Thanks again! |
Benchmark runs are scheduled for baseline = b8c04c8 and contender = 07e7009. 07e7009 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <[email protected]> Signed-off-by: Matt Topol <[email protected]>
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <[email protected]> Signed-off-by: Matt Topol <[email protected]>
…rvices (apache#13995) This PR exposes `grpc.ServiceRegistrar` and `reflection.ServiceInfoProvider` in `grpc.Server`. They are needed to register additional gRPC services such as health check and reflection. Authored-by: Jie Zhang <[email protected]> Signed-off-by: Matt Topol <[email protected]>
This PR exposes
grpc.ServiceRegistrar
andreflection.ServiceInfoProvider
ingrpc.Server
. They are needed to register additional gRPC services such as health check and reflection.