Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [Archery] Improve crossbow report-pr ergonomics #13994

Merged
merged 1 commit into from
Aug 29, 2022
Merged

MINOR: [Archery] Improve crossbow report-pr ergonomics #13994

merged 1 commit into from
Aug 29, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 29, 2022

  • If a pull request with the given title is not found, also print the repo name.
  • Allow shorthand "username/reponame" as remote, in addition to full Github URLs.

@pitrou
MINOR: [Archery] Improve crossbow report-pr ergonomics
4832294 
* If a pull request with the given title is not found, also print the repo name.
* Allow shorthand "username/reponame" as remote, in addition to full Github URLs.
@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2022

@raulcd Can you give this a look?

raulcd
raulcd approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pitrou!

@pitrou pitrou merged commit b8c04c8 into apache:master Aug 29, 2022
@pitrou pitrou deleted the archery-report-pr branch August 29, 2022 18:08
@ursabot
Copy link

ursabot commented Aug 29, 2022

Benchmark runs are scheduled for baseline = 9d86755 and contender = b8c04c8. b8c04c8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b8c04c85 ec2-t3-xlarge-us-east-2
[Failed] b8c04c85 test-mac-arm
[Failed] b8c04c85 ursa-i9-9960x
[Finished] b8c04c85 ursa-thinkcentre-m75q
[Finished] 9d867558 ec2-t3-xlarge-us-east-2
[Failed] 9d867558 test-mac-arm
[Failed] 9d867558 ursa-i9-9960x
[Finished] 9d867558 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 29, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@pitrou @anjakefala
MINOR: [Archery] Improve crossbow report-pr ergonomics (apache#13994)
a7155a2 
* If a pull request with the given title is not found, also print the repo name.
* Allow shorthand "username/reponame" as remote, in addition to full Github URLs.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou @zagto
MINOR: [Archery] Improve crossbow report-pr ergonomics (apache#13994)
fef9758 
* If a pull request with the given title is not found, also print the repo name.
* Allow shorthand "username/reponame" as remote, in addition to full Github URLs.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@pitrou @fatemehp
MINOR: [Archery] Improve crossbow report-pr ergonomics (apache#13994)
10b7e81 
* If a pull request with the given title is not found, also print the repo name.
* Allow shorthand "username/reponame" as remote, in addition to full Github URLs.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @ursabot @raulcd