ARROW-14495: [Python] Fix DictionaryArray.from_buffers, should not crash #13989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Requires modifying signature to take dictionary as well as the buffers.
jorisvandenbossche
approved these changes
Aug 29, 2022
| with nogil: | ||
| c_data = CArrayData.Make( | ||
| c_type, length, c_buffers, null_count, offset) | ||
| c_data.get().dictionary = dictionary.sp_array.get().data() |
There was a problem hiding this comment.
There is a ArrayData::Make variant that directly accepts a dictionary, but that might not be worth exposing for just this one line.
There was a problem hiding this comment.
I saw that, and it appears to essentially do the same; creating ArrayData then setting the dictionary member. Using it this way, we don't need to pass (null?) child data, albeit, if that way is the preferred method I have no problem switching. 👍
pitrou
reviewed
Aug 30, 2022
[skip ci] Co-authored-by: Antoine Pitrou <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
|
@pitrou I think this is ready for another round. :) |
milesgranger
deleted the
ARROW-14495_DictionaryArray-from_buffers-should-not-crash
branch
zagto
pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
…ash (apache#13989) Fix [ARROW-14495](https://issues.apache.org/jira/browse/ARROW-14495) Authored-by: Miles Granger <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
fatemehp
pushed a commit
to fatemehp/arrow
that referenced
this pull request
Oct 17, 2022
…ash (apache#13989) Fix [ARROW-14495](https://issues.apache.org/jira/browse/ARROW-14495) Authored-by: Miles Granger <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ARROW-14495