ARROW-17079: [C++] Improve error messages for AWS S3 calls #13979
Conversation
|
|
kou
changed the title
|
@pitrou Do you want to have a look at / review this PR? |
|
Yes of course! For example for loading a dataset from After (changes in bold):
Before:
For comparison, this is how the same information is incorporated into boto3 errors:
I'm happy to use the exact same phrasing as boto3 if that's desired -- I'll do a follow up PR with the error codes substituted with actual errors and can change it then if desired. |
|
Benchmark runs are scheduled for baseline = d7eea09 and contender = b43c6f6. b43c6f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
) First part of improving error messages from S3 operations. We include the operation that failed in the error message now. This makes it easier to debug problems (e.g. bucket permissions or other infrastructure hickups) because it allows to re-run the operation that failed with the AWS CLI for further diagnosing what is going wrong. Example (changes in bold): > When getting information for key 'test.csv' in bucket 'pcmoritz-test-bucket-arrow-errors': AWS Error [code 15] **during HeadObject operation**: No response body. Authored-by: Philipp Moritz <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
) First part of improving error messages from S3 operations. We include the operation that failed in the error message now. This makes it easier to debug problems (e.g. bucket permissions or other infrastructure hickups) because it allows to re-run the operation that failed with the AWS CLI for further diagnosing what is going wrong. Example (changes in bold): > When getting information for key 'test.csv' in bucket 'pcmoritz-test-bucket-arrow-errors': AWS Error [code 15] **during HeadObject operation**: No response body. Authored-by: Philipp Moritz <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
) First part of improving error messages from S3 operations. We include the operation that failed in the error message now. This makes it easier to debug problems (e.g. bucket permissions or other infrastructure hickups) because it allows to re-run the operation that failed with the AWS CLI for further diagnosing what is going wrong. Example (changes in bold): > When getting information for key 'test.csv' in bucket 'pcmoritz-test-bucket-arrow-errors': AWS Error [code 15] **during HeadObject operation**: No response body. Authored-by: Philipp Moritz <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
First part of improving error messages from S3 operations. We include the operation that failed in the error message now. This makes it easier to debug problems (e.g. bucket permissions or other infrastructure hickups) because it allows to re-run the operation that failed with the AWS CLI for further diagnosing what is going wrong.
Example (changes in bold):