Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17518: [CI][Doc][Python] Update glob to detect arrow development version from git #13966

Merged
merged 1 commit into from
Aug 25, 2022
Merged

ARROW-17518: [CI][Doc][Python] Update glob to detect arrow development version from git #13966

merged 1 commit into from
Aug 25, 2022

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Aug 24, 2022

Reproduced locally:

$ git describe --dirty --tags --long --match "apache-arrow-[0-9].*"
apache-arrow-9.0.0.dev-641-g0d5bb92-dirty
$ git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"
apache-arrow-10.0.0.dev-114-g0d5bb92-dirty

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17518

pitrou
pitrou reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the issue @raulcd !
Can you mark this PR ready?

dev/archery/archery/crossbow/core.py Show resolved Hide resolved
python/pyarrow/__init__.py Show resolved Hide resolved
python/setup.py Show resolved Hide resolved
@pitrou
Copy link
Member

pitrou commented Aug 25, 2022

Also, can you please rebase to get a passing AppVeyor build?

@raulcd raulcd marked this pull request as ready for review August 25, 2022 07:42
@raulcd
Copy link
Member Author

raulcd commented Aug 25, 2022

As it can be seen on the builds: https://github.com/apache/arrow/runs/8010907934?check_suite_focus=true#step:6:1322
the new version is selected correctly:
ARROW_GIT_DESCRIPTION=apache-arrow-10.0.0.dev-120-g4e1922569
or
pyarrow==10.0.0.dev120+g4e1922569
which was not correct previously.

pitrou
pitrou approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diagnosing and fixing this @raulcd :-)

@pitrou pitrou merged commit f2bac9b into apache:master Aug 25, 2022
@ursabot
Copy link

ursabot commented Aug 25, 2022

Benchmark runs are scheduled for baseline = dd0988b and contender = f2bac9b. f2bac9b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.17% ⬆️0.0%] test-mac-arm
[Failed ⬇️5.48% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.11%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f2bac9b6 ec2-t3-xlarge-us-east-2
[Finished] f2bac9b6 test-mac-arm
[Failed] f2bac9b6 ursa-i9-9960x
[Finished] f2bac9b6 ursa-thinkcentre-m75q
[Finished] dd0988b4 ec2-t3-xlarge-us-east-2
[Failed] dd0988b4 test-mac-arm
[Failed] dd0988b4 ursa-i9-9960x
[Finished] dd0988b4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 25, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@raulcd @anjakefala
ARROW-17518: [CI][Doc][Python] Update glob to detect arrow developmen…
687438d 
…t version from git (apache#13966)

Reproduced locally:
```
$ git describe --dirty --tags --long --match "apache-arrow-[0-9].*"
apache-arrow-9.0.0.dev-641-g0d5bb92-dirty
$ git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"
apache-arrow-10.0.0.dev-114-g0d5bb92-dirty
```

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@raulcd @zagto
ARROW-17518: [CI][Doc][Python] Update glob to detect arrow developmen…
adc9bbe 
…t version from git (apache#13966)

Reproduced locally:
```
$ git describe --dirty --tags --long --match "apache-arrow-[0-9].*"
apache-arrow-9.0.0.dev-641-g0d5bb92-dirty
$ git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"
apache-arrow-10.0.0.dev-114-g0d5bb92-dirty
```

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@raulcd @fatemehp
ARROW-17518: [CI][Doc][Python] Update glob to detect arrow developmen…
64c2f46 
…t version from git (apache#13966)

Reproduced locally:
```
$ git describe --dirty --tags --long --match "apache-arrow-[0-9].*"
apache-arrow-9.0.0.dev-641-g0d5bb92-dirty
$ git describe --dirty --tags --long --match "apache-arrow-[0-9]*.*"
apache-arrow-10.0.0.dev-114-g0d5bb92-dirty
```

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulcd @pitrou @ursabot