Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17517: [C++] Test engine API in public API test #13965

Merged
merged 2 commits into from
Sep 20, 2022
Merged

ARROW-17517: [C++] Test engine API in public API test #13965

merged 2 commits into from
Sep 20, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 24, 2022 •
edited
Loading

Also some assorted header inclusion cleanups.

Followup to PR #13965.

@pitrou
Copy link
Member Author

pitrou commented Aug 24, 2022

This is a crude way to solve the issue and some more elaborate solution could probably be pushed. @westonpace

@pitrou pitrou mentioned this pull request Aug 24, 2022
Closed
@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17517

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@pitrou
Copy link
Member Author

pitrou commented Sep 13, 2022

@westonpace @aucahuasi Some engine maintainer should probably take this task up.

@pitrou
ARROW-17517: [C++] Test engine API in public API test
60db092 
Also some assorted header inclusion cleanups.
@pitrou pitrou force-pushed the ARROW-17517-engine-api branch from 8280fc6 to 60db092 Compare September 19, 2022 19:38
@pitrou pitrou changed the title ARROW-17517: [C++] Avoid exposing internal headers from engine/api.h ARROW-17517: [C++] Test engine API in public API test Sep 19, 2022
@pitrou pitrou requested a review from westonpace September 19, 2022 19:39
@pitrou
Copy link
Member Author

pitrou commented Sep 19, 2022

@westonpace I updated this to just contain the test additions and a few cleanups.

@pitrou pitrou force-pushed the ARROW-17517-engine-api branch from 7dfcc71 to 8606e6f Compare September 19, 2022 21:13
westonpace
westonpace approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the further cleanup.

@pitrou
Copy link
Member Author

pitrou commented Sep 20, 2022

The LLVM deprecation errors are unrelated.

@pitrou pitrou merged commit cd67e51 into apache:master Sep 20, 2022
@pitrou pitrou deleted the ARROW-17517-engine-api branch September 20, 2022 07:10
@ursabot
Copy link

ursabot commented Sep 20, 2022

Benchmark runs are scheduled for baseline = b97497a and contender = cd67e51. cd67e51 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.48% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cd67e519 ec2-t3-xlarge-us-east-2
[Failed] cd67e519 test-mac-arm
[Failed] cd67e519 ursa-i9-9960x
[Finished] cd67e519 ursa-thinkcentre-m75q
[Finished] b97497aa ec2-t3-xlarge-us-east-2
[Failed] b97497aa test-mac-arm
[Failed] b97497aa ursa-i9-9960x
[Finished] b97497aa ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou @zagto
ARROW-17517: [C++] Test engine API in public API test (apache#13965)
0386546 
Also some assorted header inclusion cleanups.

Followup to PR apache#13965.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@pitrou @fatemehp
ARROW-17517: [C++] Test engine API in public API test (apache#13965)
ca09ee4 
Also some assorted header inclusion cleanups.

Followup to PR apache#13965.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@asfimport asfimport mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @ursabot @westonpace