Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [CI] [C++] Pin xsimd version to 8.1.0 in CPP conda env file #13956

Closed
wants to merge 1 commit into from

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Aug 24, 2022

This fixes local and CI builds that use conda now that xsimd 9.0.0 has been published to conda-forge. cpp/cmake_modules/ThirdpartyToolchain.cmake has a strict dependency on xsimd 8.1.0 and this should fix builds until upgrading to xsimd 9.0.0 can be evaluated.

@kou
Copy link
Member

kou commented Aug 24, 2022

FYI: I"m working on xsimd 8.1.0 and 9.0.0 support in #13903

@kou
Copy link
Member

kou commented Aug 24, 2022

I've extracted it to #13958.
BTW, what CI jobs were failed?

@amoeba
Copy link
Member Author

amoeba commented Aug 24, 2022

So far just AppVeyor (thanks @westonpace for noticing) but it looks like the C++ workflow should fail unless caching is keeping it from pulling the updated version from conda-forge or it's building xsmid from source instead. All that said, #13958 looks preferable over this PR so feel free to close.

@raulcd
Copy link
Member

raulcd commented Aug 24, 2022

There were a couple of nightly build failures too:
test-conda-cpp-valgrind and example-python-minimal-build-fedora-conda

@kou
Copy link
Member

kou commented Aug 24, 2022

Thanks!
I've started these jobs in #13958.

I close this in favor of #13958.

@kou kou closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants