-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array #13950
ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array #13950
Conversation
|
@pitrou I believe this is ready for a review. |
python/pyarrow/tests/test_table.py
Outdated
@@ -143,14 +140,15 @@ def test_chunked_array_to_numpy(): | |||
|
|||
|
|||
def test_chunked_array_mismatch_types(): | |||
with pytest.raises(TypeError): | |||
msg = "chunks must all be same type" | |||
with pytest.raises(pa.ArrowInvalid, match=msg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... interesting. I would be in favor of changing the C++ side to return TypeError
instead. Would you like to do that in this PR?
python/pyarrow/tests/test_table.py
Outdated
# Given array types are different | ||
pa.chunked_array([ | ||
pa.array([1, 2, 3]), | ||
pa.array([1., 2., 3.]) | ||
]) | ||
|
||
with pytest.raises(TypeError): | ||
with pytest.raises(pa.ArrowInvalid, match=msg): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same)
I don't think the R / AMD64 Windows R 3.6 RTools 35 failure is related... |
Indeed, it isn't. |
Rebased and a nit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger !
Python CI was successful here: https://github.com/milesgranger/arrow/actions/runs/2924730791 |
Benchmark runs are scheduled for baseline = 897c186 and contender = dd0988b. dd0988b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…pache#13950) Supersedes and will close apache#12096 [ARROW-15277](https://issues.apache.org/jira/browse/ARROW-15277) Lead-authored-by: Miles Granger <[email protected]> Co-authored-by: Eduardo Ponce <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#13950) Supersedes and will close apache#12096 [ARROW-15277](https://issues.apache.org/jira/browse/ARROW-15277) Lead-authored-by: Miles Granger <[email protected]> Co-authored-by: Eduardo Ponce <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#13950) Supersedes and will close apache#12096 [ARROW-15277](https://issues.apache.org/jira/browse/ARROW-15277) Lead-authored-by: Miles Granger <[email protected]> Co-authored-by: Eduardo Ponce <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Supersedes and will close #12096
ARROW-15277