Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS #13925

Merged
merged 9 commits into from
Sep 12, 2022

Conversation

assignUser
Copy link
Member

No description provided.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions
Copy link

Revision: 2d61573

Submitted crossbow builds: ursacomputing/crossbow @ actions-968ba3a186

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

@jonkeane 🥳

@assignUser
Copy link
Member Author

There was an (unrelated) issue with fetching httr which seems to be resolved now.

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: f5b72eb

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f51137b82

Task Status
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Revision: 9437458

Submitted crossbow builds: ursacomputing/crossbow @ actions-070d238cc8

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

The test failure for autobrew is caused by this #13955 the actual build and install works fine. A rebase should fix it.

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Revision: 8c43d03

Submitted crossbow builds: ursacomputing/crossbow @ actions-5e21bb0b0b

Task Status
homebrew-r-autobrew Github Actions

@assignUser assignUser requested a review from pitrou September 7, 2022 11:03
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really competent on this, just a question.

dev/tasks/r/github.packages.yml Show resolved Hide resolved
@assignUser assignUser requested a review from pitrou September 9, 2022 09:18
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Perhaps you can find a R reviewer though? @nealrichardson

@nealrichardson
Copy link
Member

I don't understand, what's up with the autobrew job? There don't appear to be any changes to that workflow in this PR. And it looks like it's running 2x the number of builds it should?

@assignUser
Copy link
Member Author

@nealrichardson there were some changes to the autobrew job (clean up, now integrated into the self-hosted runner cleanup script)

I than re-ran only the autobrew job after the rebase to make sure it worked but I should have ran the other on too. Will start it in a sec. The switch to running autobrew for both oldrel and release was here, if you think that's unnecessary we can run it on release only?

@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@nealrichardson
Copy link
Member

The autobrew job names don't indicate that they're running different R versions, so they look like they're duplicate. Let's fix that.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Revision: b40cb0c

Submitted crossbow builds: ursacomputing/crossbow @ actions-3be0728d28

Task Status
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: 273b51f

Submitted crossbow builds: ursacomputing/crossbow @ actions-49eeb539c5

Task Status
homebrew-r-autobrew Github Actions

@assignUser
Copy link
Member Author

@nealrichardson
grafik

@nealrichardson nealrichardson merged commit 6c675c3 into apache:master Sep 12, 2022
@assignUser assignUser deleted the nightly-old-macos branch September 12, 2022 17:20
@ursabot
Copy link

ursabot commented Sep 13, 2022

Benchmark runs are scheduled for baseline = 05b7fe3 and contender = 6c675c3. 6c675c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.24% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6c675c35 ec2-t3-xlarge-us-east-2
[Finished] 6c675c35 test-mac-arm
[Failed] 6c675c35 ursa-i9-9960x
[Finished] 6c675c35 ursa-thinkcentre-m75q
[Finished] 05b7fe35 ec2-t3-xlarge-us-east-2
[Failed] 05b7fe35 test-mac-arm
[Failed] 05b7fe35 ursa-i9-9960x
[Finished] 05b7fe35 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants