You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing compute module, which makes sense since it isn't really finished and only provides limited utility currently.
This change will mark the compute module as a separate sub-module inside of the arrow module, allowing us to use go1.18 in this new code without forcing anyone who isn't using the compute module to upgrade. That way I can leverage the generics when writing the new compute code where appropriate.
…pache#13910)
I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing `compute` module, which makes sense since it isn't really finished and only provides limited utility currently.
This change will mark the `compute` module as a separate sub-module inside of the `arrow` module, allowing us to use `go1.18` in this new code without forcing anyone who *isn't* using the compute module to upgrade. That way I can leverage the generics when writing the new compute code where appropriate.
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zeroshade
force-pushed
the
arrow-17456-computemodule
branch
from
I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing
computemodule, which makes sense since it isn't really finished and only provides limited utility currently.This change will mark the
computemodule as a separate sub-module inside of thearrowmodule, allowing us to usego1.18in this new code without forcing anyone who isn't using the compute module to upgrade. That way I can leverage the generics when writing the new compute code where appropriate.