Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16295: [CI][Release] Use windows-2019 for verify-rc-source-windows #12970

Closed
wants to merge 3 commits into from
Closed

ARROW-16295: [CI][Release] Use windows-2019 for verify-rc-source-windows #12970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a480458
ARROW-16295: [CI][Release] Use windows-2019 for verify-rc-source-windows
kou Apr 23, 2022
8dbe6ac
Use Visual Studio 16
kou Apr 23, 2022
6b820c5
Fix a typo
kou Apr 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dev/release/verify-release-candidate.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ call activate %_VERIFICATION_CONDA_ENV% || exit /B 1
@rem for more context, see https://issues.apache.org/jira/browse/ARROW-15378
call conda remove -y gtest gmock || exit /B 1

set GENERATOR=Visual Studio 15 2017 Win64
set GENERATOR=Visual Studio 16 2019
set ARCHITECTURE=x64
set CONFIGURATION=release

pushd !ARROW_SOURCE!
Expand All @@ -93,6 +94,7 @@ call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tool
@rem generator used

cmake -G "%GENERATOR%" ^
-A "%ARCHITECTURE%" ^
-DARROW_BOOST_USE_SHARED=ON ^
-DARROW_BUILD_STATIC=OFF ^
-DARROW_BUILD_TESTS=ON ^
Expand Down
2 changes: 1 addition & 1 deletion dev/tasks/verify-rc/github.win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
jobs:
verify:
name: "Verify release candidate Windows source"
runs-on: windows-2016
runs-on: windows-2019
{% if env is defined %}
env:
{% for key, value in env.items() %}
Expand Down