Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] CMake fixes and improvements #44976

Closed
pitrou opened this issue Dec 9, 2024 · 1 comment
Closed

[C++] CMake fixes and improvements #44976

pitrou opened this issue Dec 9, 2024 · 1 comment
Assignees
@pitrou
Labels
Component: C++ Type: enhancement
Milestone
19.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Dec 9, 2024 •
edited by kou
Loading

Describe the enhancement requested

  1. Since mimalloc has become the default allocator instead of jemalloc, mimalloc should be enabled by default, and jemalloc disabled by default.
  2. compute-specific files should only be compiled when compute is enabled.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Dec 9, 2024
Merged
kou pushed a commit that referenced this issue Dec 10, 2024
@pitrou
GH-44976: [C++] Enable mimalloc by default, disable jemalloc by defau…
b907c5d 
…lt and more (#44951)

### What changes are included in this PR?

1) Disable jemalloc by default
2) Enable mimalloc by default
3) Some files in `arrow/compute` are only required when ARROW_COMPUTE is enabled, so we needn't compile them by default

### Are these changes tested?

Yes, by existing CI tests.

### Are there any user-facing changes?

Yes, but nothing compatibility-breaking.
* GitHub Issue: #44976

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 19.0.0 milestone Dec 10, 2024
@kou
Copy link
Member

kou commented Dec 10, 2024

Issue resolved by pull request 44951
#44951

@kou kou closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @pitrou