[Python] Clean-up name / field_name handling in pandas compat #44962
Comments
raulcd
pushed a commit
that referenced
this issue
Dec 11, 2024
…at (#44963) ### Rationale for this change Small part of #44195 factored out into its own PR because this change is just a small refactor making #44195 easier to do, but in itself not changing any logic. We currently both store `name` and `field_name` in the pandas metadata. `field_name` is guaranteed to be a string, and is always exactly the name used in the arrow schema. `name` can also be None if the original pandas DataFrame used None as the column label or if it was coming from an index level without name. Right now we had several places where we used `name` but then checked for it being None. With this PR I made it more consistently use `field_name` in the cases it needs the string version, by more consistently passing through both names a field_names. ### Are these changes tested? Existing tests should cover this ### Are there any user-facing changes? No * Issue: #44962 * GitHub Issue: #44962 Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
Issue resolved by pull request 44963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Small part of #44195 factored out into its own PR because this change is just a small refactor making #44195 easier to do, but in itself not changing any logic.
We currently both store
nameandfield_namein the pandas metadata.field_nameis guaranteed to be a string, and is always exactly the name used in the arrow schema.namecan also be None if the original pandas DataFrame used None as the column label or if it was coming from an index level without name.Right now we had several places where we used
namebut then checked for it being None. We can make it more consistently usefield_namein the cases it needs the string version.The text was updated successfully, but these errors were encountered: