Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib][Ruby][Flight] allow setting CallOption timeout #44178

Closed
datbth opened this issue Sep 21, 2024 · 1 comment
Closed

[GLib][Ruby][Flight] allow setting CallOption timeout #44178

datbth opened this issue Sep 21, 2024 · 1 comment
Assignees
@datbth
Labels
Component: GLib Component: Ruby Type: enhancement
Milestone
18.0.0

Comments

@datbth
Copy link

datbth commented Sep 21, 2024

Describe the enhancement requested

Currently, it's not possible to set the timeout option of FlightCallOptions via Ruby ArrowFlight::CallOptions.
Can you expose a method for setting it in flight glib and ruby?

Thank you.

Component(s)

GLib, Ruby
@datbth datbth mentioned this issue Sep 21, 2024
Closed
kou added a commit to kou/arrow that referenced this issue Sep 22, 2024
@kou
apacheGH-44178: [GLib][FlightRPC] Add GAFlightCallOptions:timeout
6bab6e9
@github-actions github-actions bot mentioned this issue Sep 22, 2024
Merged
kou added a commit that referenced this issue Sep 24, 2024
@kou
GH-44178: [GLib][FlightRPC] Add GAFlightCallOptions:timeout (#44181)
508eb2f 
### Rationale for this change

It's the bindings of `arrow::flight::FlightCallOptions::timeout`.

### What changes are included in this PR?

Add `GAFlightCallOptions:timeout` property.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #44178

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Sep 24, 2024
@kou
Copy link
Member

kou commented Sep 24, 2024

Issue resolved by pull request 44181
#44181

@kou kou closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datbth datbth

Labels
Component: GLib Component: Ruby Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @datbth