Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Add Python wrapper for JsonExtensionType #44066

Closed
rok opened this issue Sep 11, 2024 · 5 comments
Closed

[Python] Add Python wrapper for JsonExtensionType #44066

rok opened this issue Sep 11, 2024 · 5 comments
Assignees
@rok
Labels
backport-candidate Component: Python Type: enhancement
Milestone
19.0.0

Comments

@rok
Copy link
Member

rok commented Sep 11, 2024

Describe the enhancement requested

We added JsonExtensionType and we should make it usable from Python.

Component(s)

Python
@rok rok mentioned this issue Sep 11, 2024
Merged
@github-actions github-actions bot mentioned this issue Sep 11, 2024
Merged
@AlenkaF AlenkaF added this to the 19.0.0 milestone Oct 2, 2024
@jorisvandenbossche jorisvandenbossche modified the milestones: 19.0.0, 18.0.0 Oct 2, 2024
@AlenkaF AlenkaF added the Priority: Blocker Marks a blocker for the release label Oct 2, 2024
@raulcd
Copy link
Member

raulcd commented Oct 10, 2024

should this be a release blocker? @jorisvandenbossche @rok

@rok
Copy link
Member Author

rok commented Oct 10, 2024

It's a nice to have for me, as it matches duckdb adding it. duckdb/duckdb#13446

@raulcd
Copy link
Member

raulcd commented Oct 13, 2024

I am really close to create RC0. I don't think we should block the release for this. I'll move this to 19.0.0 once I create RC0

@raulcd raulcd removed the Priority: Blocker Marks a blocker for the release label Oct 13, 2024
@rok
Copy link
Member Author

rok commented Oct 13, 2024

Please go ahead.

@raulcd raulcd modified the milestones: 18.0.0, 19.0.0 Oct 14, 2024
pitrou pushed a commit that referenced this issue Oct 22, 2024
@rok @jorisvandenbossche
GH-44066: [Python] Add Python wrapper for JsonExtensionType (#44070)
bcb4653 
### Rationale for this change

We [added canonical JsonExtensionType](#13901) and we should make it usable from Python.

### What changes are included in this PR?

Python wrapper for `JsonExtensionType` and `JsonArray` are added on Python side as well as `JsonArray` on c++ side.

### Are these changes tested?

Python tests for the extension type and array are included.

### Are there any user-facing changes?

This adds a json canonical extension type to pyarrow.
* GitHub Issue: #44066

Lead-authored-by: Rok Mihevc <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou
Copy link
Member

pitrou commented Oct 22, 2024

Issue resolved by pull request 44070
#44070

@pitrou pitrou closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rok rok

Labels
backport-candidate Component: Python Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
5 participants
@rok @raulcd @jorisvandenbossche @pitrou @AlenkaF