Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] IPC: Trivial C++ code enhancement #44036

Closed
mapleFU opened this issue Sep 10, 2024 · 1 comment
Closed

[C++] IPC: Trivial C++ code enhancement #44036

mapleFU opened this issue Sep 10, 2024 · 1 comment
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Sep 10, 2024

Describe the enhancement requested

Using less std::shared_ptr copying

Component(s)

C++
@github-actions github-actions bot mentioned this issue Sep 10, 2024
Merged
kou pushed a commit that referenced this issue Sep 10, 2024
@mapleFU
GH-44036: [C++] IPC: ipc reader/writer code enhancement (#44019)
b6316c0 
### Rationale for this change

So minor ipc code enhancement when I read the code

### What changes are included in this PR?

Avoid copying shared_ptr in some naive space

### Are these changes tested?

Covered by existence

### Are there any user-facing changes?

no

* GitHub Issue: #44036

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Sep 10, 2024
@kou
Copy link
Member

kou commented Sep 10, 2024

Issue resolved by pull request 44019
#44019

@kou kou closed this as completed Sep 10, 2024
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@mapleFU @khwilson
apacheGH-44036: [C++] IPC: ipc reader/writer code enhancement (apache…
ab90f74 
…#44019)

### Rationale for this change

So minor ipc code enhancement when I read the code

### What changes are included in this PR?

Avoid copying shared_ptr in some naive space

### Are these changes tested?

Covered by existence

### Are there any user-facing changes?

no

* GitHub Issue: apache#44036

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
zeroshade pushed a commit to zeroshade/arrow that referenced this issue Sep 30, 2024
@mapleFU @zeroshade
apacheGH-44036: [C++] IPC: ipc reader/writer code enhancement (apache…
df5d8bc 
…#44019)

### Rationale for this change

So minor ipc code enhancement when I read the code

### What changes are included in this PR?

Avoid copying shared_ptr in some naive space

### Are these changes tested?

Covered by existence

### Are there any user-facing changes?

no

* GitHub Issue: apache#44036

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @mapleFU