Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Minor: enhance the std::move usage in list type #43992

Closed
mapleFU opened this issue Sep 6, 2024 · 1 comment
Closed

[C++] Minor: enhance the std::move usage in list type #43992

mapleFU opened this issue Sep 6, 2024 · 1 comment
Assignees
@mapleFU
Labels
Component: C++ Type: enhancement
Milestone
18.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented Sep 6, 2024

Describe the enhancement requested

Currently list code don't move for bitmap, should use that to optimize

Component(s)

C++
@github-actions github-actions bot mentioned this issue Sep 6, 2024
Merged
kou pushed a commit that referenced this issue Sep 6, 2024
@mapleFU
GH-43992: [C++] Add missing std::move() in array_nested.cc (#43993)
7d49420 
### Rationale for this change

Minor code enhancement in array_nested.cc

### What changes are included in this PR?

Use std::move for nested types

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: #43992

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Sep 6, 2024
@kou
Copy link
Member

kou commented Sep 6, 2024

Issue resolved by pull request 43993
#43993

@kou kou closed this as completed Sep 6, 2024
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@mapleFU @khwilson
apacheGH-43992: [C++] Add missing std::move() in array_nested.cc (apa…
df4d396 
…che#43993)

### Rationale for this change

Minor code enhancement in array_nested.cc

### What changes are included in this PR?

Use std::move for nested types

### Are these changes tested?

Covered by existing

### Are there any user-facing changes?

no

* GitHub Issue: apache#43992

Authored-by: mwish <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @mapleFU